Skip to content

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Feb 9, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1815
🦕

@tswast tswast requested review from a team as code owners February 9, 2024 22:54
@tswast tswast requested a review from nayaknishant February 9, 2024 22:54
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery API. labels Feb 9, 2024
@tswast tswast requested review from chalmerlowe and Linchin and removed request for nayaknishant February 9, 2024 22:54
Copy link
Contributor

@Linchin Linchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I think this doesn't just apply to Int64, but also the rest of nullable int types: Int64, Int32, Int16, Int8, UInt64, UInt32, UInt16 and UInt8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

insert_rows_from_dataframe doesn't support nullable boolean or nullable Int64 dtypes
2 participants