Skip to content

feat: add ability to set autodetect_schema query param in update_table #2171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 12, 2025
Merged

feat: add ability to set autodetect_schema query param in update_table #2171

merged 6 commits into from
May 12, 2025

Conversation

TheNeuralBit
Copy link
Contributor

Fixes #2170

@TheNeuralBit TheNeuralBit requested review from a team as code owners May 1, 2025 19:58
@TheNeuralBit TheNeuralBit requested a review from shollyman May 1, 2025 19:58
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery API. labels May 1, 2025
@TheNeuralBit TheNeuralBit changed the title Add ability to set autodetectSchema query param in update_table PATCH call Add ability to set autodetect_schema query_param May 1, 2025
@alvarowolfx alvarowolfx assigned Linchin and unassigned alvarowolfx May 2, 2025
@chalmerlowe chalmerlowe added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 2, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 2, 2025
@chalmerlowe chalmerlowe assigned chalmerlowe and unassigned Linchin May 2, 2025
@chalmerlowe
Copy link
Collaborator

I reviewed this. I have a PR I want to merge into this branch, but there are some failing tests so I am working through that. More to come.

@TheNeuralBit TheNeuralBit changed the title Add ability to set autodetect_schema query_param feat: add ability to set autodetect_schema query param in update_table May 7, 2025
@chalmerlowe chalmerlowe added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 7, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 7, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 7, 2025
chalmerlowe
chalmerlowe requested changes May 12, 2025
View reviewed changes
Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got a couple preferences. If you are amenable, please update.
If tests pass, we can approve.

@TheNeuralBit
Copy link
Contributor Author

Thanks @chalmerlowe I applied all your suggestions in b329cd0. Do you know why the test runs seem to be stuck?

@chalmerlowe chalmerlowe added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 12, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 12, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 12, 2025
chalmerlowe
chalmerlowe approved these changes May 12, 2025
View reviewed changes
Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalmerlowe chalmerlowe merged commit 57f940d into googleapis:main May 12, 2025
14 checks passed
@release-please release-please bot mentioned this pull request May 12, 2025
Merged
This was referenced May 28, 2025
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalmerlowe chalmerlowe chalmerlowe approved these changes

@shollyman shollyman Awaiting requested review from shollyman shollyman is a code owner automatically assigned from googleapis/api-bigquery

Assignees

@chalmerlowe chalmerlowe

Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update_table should support setting autodetectSchema query param in PATCH call
5 participants
@TheNeuralBit @chalmerlowe @alvarowolfx @Linchin @yoshi-kokoro