Skip to content

Conversation

@daniel-sanche
Copy link
Contributor

The continuous kokoro test should use the same configuration as the pre-submit

@daniel-sanche daniel-sanche requested review from a team as code owners November 18, 2025 22:51
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Nov 18, 2025
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/python-datastore API. label Nov 18, 2025
# Format: //devtools/kokoro/config/proto/build.proto
# Format: //devtools/kokoro/config/proto/build.proto

# Disable system tests.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also add a configuration for system tests similar to the ones in https://github.com/googleapis/python-datastore/tree/main/.kokoro/presubmit?

It looks like currently only system-3.12.cfg is being used

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean changing NOX_SESSION like this?

env_vars: {
    key: "NOX_SESSION"
    value: "blacken doctests format system-3.12"
}

I think for the system configuration files to work, we'd need to make changes to google3

@bhshkh bhshkh assigned daniel-sanche and unassigned bhshkh Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastore Issues related to the googleapis/python-datastore API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants