Skip to content

Lint session fails with flake8==6.1.0 #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
parthea opened this issue Aug 3, 2023 · 1 comment · Fixed by #211
Closed

Lint session fails with flake8==6.1.0 #199

parthea opened this issue Aug 3, 2023 · 1 comment · Fixed by #211
Assignees
Labels
api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API.

Comments

@parthea
Copy link
Contributor

parthea commented Aug 3, 2023

flake8==6.1.0 was released on July 29th.
https://pypi.org/project/flake8/6.1.0/#history

When running the lint check with flake8==6.1.0 , the check fails with the following errors:

(py38) partheniou@partheniou-vm-3:~/git/python-db-dtypes-pandas$ nox -s lint
nox > Running session lint
nox > Creating virtual environment (virtualenv) using python3.8 in .nox/lint
nox > python -m pip install flake8 black==22.3.0
nox > black --check docs db_dtypes tests noxfile.py setup.py
All done! ✨ 🍰 ✨
23 files would be left unchanged.
nox > flake8 db_dtypes tests
db_dtypes/core.py:93:56: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
db_dtypes/core.py:96:12: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
nox > Command flake8 db_dtypes tests failed with exit code 1
nox > Session lint failed.
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. label Aug 3, 2023
@parthea parthea changed the title Lint session fails with flake8==6.0.1 Lint session fails with flake8==6.1.0 Aug 3, 2023
@chalmerlowe
Copy link
Collaborator

This looks like a good intern issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants