allow async on the top level #527
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschwarzl
force-pushed
the
mschwarzl/async-top-level
branch
from
38c7bee to
e9bafb9
Compare
Liedtke
requested changes
Oct 6, 2025
| throw FuzzilliError.codeVerificationError("operation \(instr.op.name) inside an invalid context") | ||
|
|
||
| // allow top-level await | ||
| if !(instr.op is Await) { |
There was a problem hiding this comment.
This doesn't change that the Await operation will still be marked as requiredContext: [.javascript, .asyncFunction]. If anything, we should remove the .asyncFunction there. However, that would also allow await in synchronous functions etc.
So if we wanted to also allow code generators that emit Await on the top-level, we would need some way to annotate that at least on the code generator. (And furthermore we'd need some notion of whether the top level is a module or not.)
There was a problem hiding this comment.
true - I'll investigate this once I have more resources working on that project again!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.