Skip to content

Tracking issue for Server.getListenSockets() being experimental #5332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
carl-mastrangelo opened this issue Feb 7, 2019 · 3 comments · Fixed by #10910
Closed

Tracking issue for Server.getListenSockets() being experimental #5332

carl-mastrangelo opened this issue Feb 7, 2019 · 3 comments · Fixed by #10910
Labels
experimental API Issue tracks stabilizing an experimental API
Milestone
1.63

Comments

@carl-mastrangelo
Copy link
Contributor

Usage:

  • Server.getListenSockets()
@carl-mastrangelo carl-mastrangelo added this to the Unscheduled milestone Feb 7, 2019
@ejona86 ejona86 added experimental API Issue tracks stabilizing an experimental API and removed Type: Documentation labels Feb 16, 2023
@xumanbu xumanbu mentioned this issue Mar 15, 2023
Merged
@YifeiZhuang
Copy link
Member

YifeiZhuang commented Oct 18, 2023 •
edited
Loading

It looks OkHttpServer and InProcessServer does not implement Server (they implement InternalServer instead, ), so they does not implement getListenSockets. The InternalServer interface has getListenerSocketAddress and getListenSocketStats. Is it a UX concern that this API only works for netty transport, but not for OkHttp and InProcess transport?

@larry-safran
Copy link
Contributor

Approved for stabilization.

@YifeiZhuang
Copy link
Member

YifeiZhuang commented Feb 7, 2024 •
edited
Loading

It looks OkHttpServer and InProcessServer does not implement Server (they implement InternalServer instead, ), so they does not implement getListenSockets. The InternalServer interface has getListenerSocketAddress and getListenSocketStats. Is it a UX concern that this API only works for netty transport, but not for OkHttp and InProcess transport?

OkHttpServer is transport. ServerImpl is built from OkHttpServerBuilder that implements Server, and OkHttpServer.getListenSocketAddresses returns listener sockets.

@YifeiZhuang YifeiZhuang mentioned this issue Feb 9, 2024
Merged
@ejona86 ejona86 modified the milestones: Unscheduled, 1.63 Feb 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
experimental API Issue tracks stabilizing an experimental API
Projects
None yet
Milestone
1.63
Development

Successfully merging a pull request may close this issue.

api: stabilize server.getListenerSockets YifeiZhuang/grpc-java
4 participants
@ejona86 @YifeiZhuang @carl-mastrangelo @larry-safran