fix: fixed download pandoc version #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yukaii
approved these changes
Dec 27, 2023
Member
Yukaii
left a comment
Yukaii
left a comment
There was a problem hiding this comment.
Seems fair! Locking the version would also improve stability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Yukaii
According to this security advisory, we need to update the Pandoc version.
Although
download.jsuses the latest release, it freezes the version when the user installs it. Therefore, we might consider fixing the Pandoc version. Each time we update the Pandoc version, we should also bump@hackmd/pandoc.js. This way, when users update their dependencies, it will trigger a reinstallation.What do you think? Thanks!