Skip to content

Conversation

@piotrex
Copy link
Contributor

@piotrex piotrex commented Jun 12, 2018

some fixes or workarounds for some errors. I needed these edits for letter 'ś' work properly and handle BadStatusLine error catch.

@piotrex
Copy link
Contributor Author

piotrex commented Jun 12, 2018

see #113

@piotrex
Copy link
Contributor Author

piotrex commented Jun 12, 2018

dont know if it good aproach but it works for me.

@jimgros
Copy link
Contributor

jimgros commented Jul 20, 2018

I used your code on searches that had previously issued a BadStatusLine error, and it solved the issue for me as well. Thanks!

@hardikvasa
Copy link
Owner

@piotrex @jimgros

thanks for pointing out this bug. Can one of answer the below questions?

  • Example of one or two keywords that leads to BadStatusLine
  • What is the python version you are using
  • Can you paste the complete error message that you have received?

I wanted to at the very least reproduce this error before merging this change. By just using 'ś' in a keyword does not lead me to the said error. Thanks.

@jimgros
Copy link
Contributor

jimgros commented Aug 15, 2018

The keywords were not the (only?) issue I think. All my keywords were in English and contained no special characters. Perhaps some of the info contained in the metadata also causes the issue...
I don't have a copy of the error message anymore.
I do not recall which string I looked for which generated the error. I can tell you that my search included related images so it's hard to pinpoint the mistake.
I think the environment I used was python 3.5 or 3.6 (I recently changed cloud providers).

I would try a few strings in English with related_image and metadata.
Maybe try a foreign city's name, written in English, but in a country that has an alphabet with different character set?
Then try that same city name in it's original language as well?
This isn't much but I hope it helps.

@hardikvasa hardikvasa merged commit a348dc4 into hardikvasa:master Apr 23, 2019
@hardikvasa
Copy link
Owner

@piotrex thanks for the PR update. For now adding exception for BadStatusLine will help identify and catch the errors. Merged the PR.

SecorD0 pushed a commit to SecorD0/google-images-download that referenced this pull request Dec 2, 2022
letter 'ś' and BadStatusLine error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants