For issues, get field `state_reason` to distinguish issues closed as `not_planned` #495

andreasabel · 2023-06-23T11:00:39Z

For issues, get field state_reason to distinguish issues closed as not_planned.
This amounts to a new enum type IssueStateReason and a new field in Issue which should be parsed here:

github/src/GitHub/Data/Issues.hs

Lines 186 to 205 in f63f92c

    
           instance FromJSON Issue where 
        
               parseJSON = withObject "Issue" $ \o -> Issue 
        
                   <$> o .:? "closed_at" 
        
                   <*> o .: "updated_at" 
        
                   <*> o .: "events_url" 
        
                   <*> o .: "html_url" 
        
                   <*> o .:? "closed_by" 
        
                   <*> o .: "labels" 
        
                   <*> o .: "number" 
        
                   <*> o .: "assignees" 
        
                   <*> o .: "user" 
        
                   <*> o .: "title" 
        
                   <*> o .:? "pull_request" 
        
                   <*> o .: "url" 
        
                   <*> o .: "created_at" 
        
                   <*> o .: "body" 
        
                   <*> o .: "state" 
        
                   <*> o .: "id" 
        
                   <*> o .: "comments" 
        
                   <*> o .:? "milestone"

According to https://docs.github.com/en/rest/issues/issues?apiVersion=2022-11-28#get-an-issue the possible values are

completed
not_planned
reopened
null

The text was updated successfully, but these errors were encountered:

andreasabel mentioned this issue Jun 23, 2023

closed-issues-for-milestone includes issues closed as "not planned" agda/agda#6699

Closed

1 task

andreasabel self-assigned this Jun 23, 2023

andreasabel added the API change label Jun 23, 2023

andreasabel added this to the 0.29 milestone Jun 23, 2023

andreasabel mentioned this issue Jun 23, 2023

Recognize state_reason fields for Issue #496

Merged

andreasabel closed this as completed in #496 Jun 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

For issues, get field `state_reason` to distinguish issues closed as `not_planned` #495

For issues, get field `state_reason` to distinguish issues closed as `not_planned` #495

andreasabel commented Jun 23, 2023 •

edited

Loading

For issues, get field state_reason to distinguish issues closed as not_planned #495

For issues, get field state_reason to distinguish issues closed as not_planned #495

Comments

andreasabel commented Jun 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

For issues, get field `state_reason` to distinguish issues closed as `not_planned` #495

For issues, get field `state_reason` to distinguish issues closed as `not_planned` #495

andreasabel commented Jun 23, 2023 •

edited

Loading