Skip to content

Changelog for 1.4.5.0 seems wrong #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
phadej opened this issue Nov 13, 2021 · 4 comments
Closed

Changelog for 1.4.5.0 seems wrong #72

phadej opened this issue Nov 13, 2021 · 4 comments

Comments

@phadej
Copy link
Contributor

phadej commented Nov 13, 2021

The changelog for 1.4.5.0 has:

Set infixr 0 for deepseq Makes infix use of 'deepseq' parse the same way as infix use of 'seq'

entry,

However:

% ghci-9.0.1
GHCi, version 9.0.1: https://www.haskell.org/ghc/  :? for help
Loaded GHCi configuration from /home/phadej/.ghci
Prelude> :m +Control.DeepSeq 
Prelude Control.DeepSeq> :i deepseq
deepseq :: NFData a => a -> b -> b 	-- Defined in ‘Control.DeepSeq’

and

deepseq-1.4.5.0 % cabal repl -w ghc-8.6.5
Resolving dependencies...
Build profile: -w ghc-8.6.5 -O1
In order, the following will be built (use -v for more details):
 - deepseq-1.4.5.0 (lib) (first run)
Configuring library for deepseq-1.4.5.0..
Preprocessing library for deepseq-1.4.5.0..
GHCi, version 8.6.5: http://www.haskell.org/ghc/  :? for help
Loaded GHCi configuration from /home/phadej/.ghci
[1 of 2] Compiling Control.DeepSeq  ( Control/DeepSeq.hs, interpreted )
[2 of 2] Compiling Control.DeepSeq.BackDoor ( Control/DeepSeq/BackDoor.hs, interpreted )
Ok, two modules loaded.
*Control.DeepSeq> :i de
decodeFloat  deepseq      denominator
*Control.DeepSeq> :i deepseq
deepseq :: NFData a => a -> b -> b
  	-- Defined at Control/DeepSeq.hs:235:1

but for 1.4.6.0:

deepseq-1.4.6.0 % cabal repl -w ghc-8.6.5  
Resolving dependencies...
Build profile: -w ghc-8.6.5 -O1
In order, the following will be built (use -v for more details):
 - deepseq-1.4.6.0 (lib) (first run)
Configuring library for deepseq-1.4.6.0..
Preprocessing library for deepseq-1.4.6.0..
GHCi, version 8.6.5: http://www.haskell.org/ghc/  :? for help
Loaded GHCi configuration from /home/phadej/.ghci
[1 of 2] Compiling Control.DeepSeq  ( Control/DeepSeq.hs, interpreted )
[2 of 2] Compiling Control.DeepSeq.BackDoor ( Control/DeepSeq/BackDoor.hs, interpreted )
Ok, two modules loaded.
*Control.DeepSeq> :i deepseq 
deepseq :: NFData a => a -> b -> b
  	-- Defined at Control/DeepSeq.hs:241:1
infixr 0 `deepseq`
@mixphix
Copy link
Collaborator

mixphix commented Nov 14, 2021

Thanks Oleg, this has been fixed.

This commit history is well and truly tangled :D

@mixphix mixphix closed this as completed Nov 14, 2021
@mixphix mixphix reopened this Nov 14, 2021
@mixphix
Copy link
Collaborator

mixphix commented Nov 14, 2021

It seems this fix wasn't as easy as I had first thought. The breaking change slipped into v1.4.6.0 which got uploaded to Hackage, but doesn't appear in the pseudo-1.4.6.0 that was forked and subsequently pinned into GHC. I've rectified the situation in v1.4.6.1.

@phadej
Copy link
Contributor Author

phadej commented Nov 14, 2021

It's not a breaking change (EDIT: worth a major release alone). See #74

@mixphix
Copy link
Collaborator

mixphix commented Nov 14, 2021

I believe the change log has been adequately rearranged despite the confusing recent history.

@mixphix mixphix closed this as completed Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants