Skip to content

haskell-process-suggest-remove-import leaves blank line rather than completely remove it #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
geraldus opened this issue Jan 25, 2016 · 4 comments

Comments

@geraldus
Copy link
Contributor

Current implementation of haskell-suggest-remove-import just clears line contents but do not removes it when user answers y. I propose to remove entire line, e.g.

import A
import D -- ^ this import is redundant
import B

-- current behavior
import A

import B

-- proposed
import A
import B
@gracjan
Copy link
Contributor

gracjan commented Feb 19, 2016

@geraldus, @chrisdone: reopened.

@geraldus
Copy link
Contributor Author

It was decided to delay this until some infrastructure improvements will be done.

@geraldus
Copy link
Contributor Author

Step 1 in direction proposed by Gracjan could be:

  1. introduce some global suggestions / info stack
  2. do not prompt user during file loading, package building, rather collect all info from compiler output to stack.
  3. ignore / mark as irrelevant messages for visited files if buffer have modified (unsaved) state.

Until overlay infrastructure is not ready:
4. after loading finished either process suggestion stack immediately or inform user to run special command.

When overlay infrastructure will be ready, we can substitute step 4.

@gracjan what do you think?

@gracjan
Copy link
Contributor

gracjan commented Mar 6, 2016

I'm okay with this plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants