Skip to content

Commit ed992b3

Browse files
committed
add relver handling and re-enable newlines
1 parent 2be0908 commit ed992b3

File tree

5 files changed

+25
-13
lines changed

5 files changed

+25
-13
lines changed

.github/workflows/online_test_deck.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,8 @@ jobs:
5656
Version: <version> (previous version: <previous>)
5757
5858
Major Components:
59-
- Kernel: <version:kernel>
60-
- Gamescope: <version:gamescope>
59+
- Kernel: <relver:kernel>
60+
- Gamescope: <relver:gamescope>
6161
- KDE: <version:kwayland>
6262
6363
Handheld Daemon:

3_chunk.sh

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,9 +103,11 @@ ostree-ext-cli \
103103
${PREV_ARG} "${OUT_REF}"
104104

105105
echo Created archive with ref ${OUT_REF}
106-
echo Writing manifests to ./$OUT_NAME.manifest.json, ./$OUT_NAME.manifest.raw.json
107-
skopeo inspect ${OUT_REF} > ${OUT_NAME}.manifest.json
108-
skopeo inspect --raw ${OUT_REF} > ${OUT_NAME}.manifest.raw.json
106+
107+
# TODO: Temporarily remove to try newlines
108+
# echo Writing manifests to ./$OUT_NAME.manifest.json, ./$OUT_NAME.manifest.raw.json
109+
# skopeo inspect ${OUT_REF} > ${OUT_NAME}.manifest.json
110+
# skopeo inspect --raw ${OUT_REF} > ${OUT_NAME}.manifest.raw.json
109111

110112
# Reset perms to make the files usable
111113
chmod 666 -R ${OUT_NAME}*

src/rechunk/fedora.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ def get_packages(dir: str):
2222
"rpm",
2323
"-qa",
2424
"--queryformat",
25-
">\n[%{FILESIZES} %{FILENAMES}\n]<%{NAME} %{NEVRA} %{VERSION}-%{RELEASE} %{SIZE}\n",
25+
">\n[%{FILESIZES} %{FILENAMES}\n]<%{NAME} %{NEVRA} %{VERSION} %{RELEASE} %{SIZE}\n",
2626
"--changes",
2727
"--dbpath",
2828
dir,
@@ -36,8 +36,11 @@ def get_packages(dir: str):
3636
name = data[0]
3737
nevra = data[1]
3838
version = data[2]
39-
size = int(data[3])
40-
package = Package(name, nevra, size, tuple(files), tuple(updates), version)
39+
release = data[3]
40+
size = int(data[4])
41+
package = Package(
42+
name, nevra, size, tuple(files), tuple(updates), version, release
43+
)
4144
packages.append(package)
4245

4346
files = []

src/rechunk/model.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ class Package(NamedTuple):
1414
files: tuple[File, ...] = tuple()
1515
updates: tuple[datetime, ...] = tuple()
1616
version: str = ""
17+
release: str = ""
1718

1819
class MetaPackage(NamedTuple):
1920
index: int

src/rechunk/utils.py

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -198,19 +198,25 @@ def get_labels(
198198
value = value.replace("<pretty>", pretty)
199199
if "<previous>" in value and prev_version:
200200
value = value.replace("<previous>", prev_version)
201-
201+
202202
if base_pkg:
203203
for pkg in base_pkg:
204204
if not pkg.version:
205205
continue
206206
vkey = f"<version:{pkg.name}>"
207207
if vkey in value:
208208
value = value.replace(vkey, pkg.version)
209+
vkey = f"<relver:{pkg.name}>"
210+
if vkey in value:
211+
value = value.replace(
212+
vkey,
213+
(
214+
f"{pkg.version}-{pkg.release}"
215+
if pkg.release
216+
else pkg.version
217+
),
218+
)
209219

210-
# OCI spec does not like new lines
211-
value = value.replace('\n', '<br>')
212-
value = value.replace('\r', '')
213-
214220
new_labels[key] = value
215221

216222
if new_labels:

0 commit comments

Comments
 (0)