Skip to content

Client type #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
taiki1frsh opened this issue Aug 27, 2022 · 5 comments
Closed

Client type #57

taiki1frsh opened this issue Aug 27, 2022 · 5 comments

Comments

@taiki1frsh
Copy link

taiki1frsh commented Aug 27, 2022

Currently ts-codegen use SigningCosmWasmClient for the client instead of CosmWasmSigner?
CosmWasmSigner is just a wrapper of SigningCosmWasmClient in ts-relayer.
But, I think it's more useful.

One of the reasons to prefer CosmWasmSigner is that it contains senderAddress to include as an argument of the many methods which SigningCosmWasmClient has.

@pyramation
Copy link
Collaborator

does it make sense to make this an option? It could make sense to do one as a default but have an option to use the CosmWasmSigner.

pardon my naivety, but would there be a reason that some developers would want to use SigningCosmWasmClient over CosmWasmSigner ?

@taiki1frsh
Copy link
Author

For less code? (by not making CosmWasmSigner over SigningCosmWasmClient.)
But, I don't see any productive reason to do so in the end.

@taiki1frsh
Copy link
Author

@pyramation
Ethan said it's better to use type from the cosmjs for ts-codegen.
So I retrieve this and request the revision about SigningCosmWasmClient in Cosmjs repo.

@pyramation
Copy link
Collaborator

oh, so does this mean we can close this issue and it will be updated in cosmjs?

I think requiring a signer from cosmjs or cosmwasm feels more official than the relayer repo.

@taiki1frsh
Copy link
Author

Yes, you can, please.

I think requiring a signer from cosmjs or cosmwasm feels more official than the relayer repo.

I also think so. hope it will be treated well there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants