Skip to content

Conversation

@zguesmi
Copy link
Member

@zguesmi zguesmi commented Oct 23, 2025

Dry runs:

=== Removing dangling deployment artifacts ===
Deleting dangling facet artifact [name:IexecAccessorsFacet, address:0xEa232be31ab0112916505Aeb7A2a94b5571DCc6b]
Deleting dangling facet artifact [name:IexecPocoBoostAccessorsFacet, address:0xa23ABb680ecc9D2A51a0CcDE88604552340786Ae]
Deleting dangling facet artifact [name:IexecPocoBoostFacet, address:0x248df8EFE953B39f965e5C7272283096d20f5956]

Skipping verification on development network: hardhat
=== Upgrade diff ===
M	.gitignore
D	deployments/hardhat/IexecAccessorsFacet.json
M	deployments/hardhat/IexecPoco1Facet.json
M	deployments/hardhat/IexecPocoAccessorsFacet.json
D	deployments/hardhat/IexecPocoBoostAccessorsFacet.json
D	deployments/hardhat/IexecPocoBoostFacet.json

Copilot AI review requested due to automatic review settings October 23, 2025 12:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds functionality to clean up deployment artifacts for facets that are no longer linked to the diamond proxy, and introduces a dry-run shell script for testing upgrades. The changes improve deployment artifact management by removing dangling facet deployments after upgrades.

Key changes:

  • Added a new function to remove deployment artifacts for facets that have been removed from the diamond proxy
  • Created a bash script to facilitate dry-run testing of upgrades with proper artifact management
  • Standardized the naming of the dry-run parameter in the GitHub Actions workflow

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

File Description
utils/proxy-tools.ts Added removeDanglingFacetDeploymentArtifacts function to clean up orphaned deployment artifacts and updated import to include deployments from hardhat
scripts/upgrades/v6.1.0-bulk-processing.ts Integrated the new artifact removal function into the upgrade process
scripts/upgrades/dry-run.sh Created new bash script to automate dry-run testing with proper deployment folder management
.github/workflows/upgrade-facets.yml Renamed dry_run parameter to dry-run and updated the workflow to use the new dry-run script

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.85%. Comparing base (17e57bc) to head (e34e577).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #300   +/-   ##
=======================================
  Coverage   84.85%   84.85%           
=======================================
  Files          37       37           
  Lines        1241     1241           
  Branches      235      235           
=======================================
  Hits         1053     1053           
  Misses        188      188           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI review requested due to automatic review settings October 23, 2025 13:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copilot AI review requested due to automatic review settings October 23, 2025 13:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@zguesmi zguesmi temporarily deployed to arbitrumSepolia October 23, 2025 13:25 — with GitHub Actions Inactive
Copilot AI review requested due to automatic review settings October 23, 2025 13:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copilot AI review requested due to automatic review settings October 23, 2025 13:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@zguesmi zguesmi self-assigned this Oct 23, 2025
@zguesmi zguesmi marked this pull request as ready for review October 23, 2025 13:36
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@zguesmi zguesmi temporarily deployed to arbitrumSepolia October 23, 2025 14:12 — with GitHub Actions Inactive
@zguesmi zguesmi merged commit 63d0017 into main Oct 23, 2025
9 of 10 checks passed
@zguesmi zguesmi deleted the feat/remove-dangling-deployment-artifacts branch October 23, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants