-
Notifications
You must be signed in to change notification settings - Fork 14
feat: Remove dangling deployment artifacts #300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds functionality to clean up deployment artifacts for facets that are no longer linked to the diamond proxy, and introduces a dry-run shell script for testing upgrades. The changes improve deployment artifact management by removing dangling facet deployments after upgrades.
Key changes:
- Added a new function to remove deployment artifacts for facets that have been removed from the diamond proxy
- Created a bash script to facilitate dry-run testing of upgrades with proper artifact management
- Standardized the naming of the
dry-runparameter in the GitHub Actions workflow
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| utils/proxy-tools.ts | Added removeDanglingFacetDeploymentArtifacts function to clean up orphaned deployment artifacts and updated import to include deployments from hardhat |
| scripts/upgrades/v6.1.0-bulk-processing.ts | Integrated the new artifact removal function into the upgrade process |
| scripts/upgrades/dry-run.sh | Created new bash script to automate dry-run testing with proper deployment folder management |
| .github/workflows/upgrade-facets.yml | Renamed dry_run parameter to dry-run and updated the workflow to use the new dry-run script |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #300 +/- ##
=======================================
Coverage 84.85% 84.85%
=======================================
Files 37 37
Lines 1241 1241
Branches 235 235
=======================================
Hits 1053 1053
Misses 188 188 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…r was skipped" This reverts commit 572b898.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Dry runs: