feat: add bulk processing support #525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeddikBellamine
changed the title
PierreJeanjacquot
force-pushed
the
feat/add-bulk-processing-support
branch
3 times, most recently
from
88e67f3 to
6849201
Compare
PierreJeanjacquot
force-pushed
the
feat/add-bulk-processing-support
branch
3 times, most recently
from
49645bf to
2250b0f
Compare
PierreJeanjacquot
temporarily deployed
to
staging
GitHub Actions
Inactive
PierreJeanjacquot
temporarily deployed
to
staging
GitHub Actions
Inactive
PierreJeanjacquot
force-pushed
the
feat/add-bulk-processing-support
branch
from
c902fc2 to
65e92b6
Compare
- Add createBulkOrder utility function for creating bulk dataset orders - Add allowBulk parameter to GrantAccessParams - Add bulk order creation flow in grantAccess function - Add CREATE_BULK_ORDER and PUBLISH_BULK_ORDER status types
- Add processBulkRequest function for processing multiple protected data orders - Implement while loop to match orders until volume is reached - Support waiting for workerpool orders when none are available - Add processBulkRequest method to IExecDataProtectorCore class - Return deals, transaction hashes, and signed request orders
- Add ProcessBulkRequestStatuses, ProcessBulkRequestParams, ProcessBulkRequestResponse types - Add allowBulk parameter to GrantAccessParams - Add bulkOnly filter to GetGrantedAccessParams - Update GrantAccessStatuses with bulk order statuses
- Add comprehensive unit tests for processBulkRequest function - Test input validation for all parameters - Test error scenarios (no app orders, whitelist validation, voucher errors) - Add mock bulk orders array for consistent testing - Remove tests that cause infinite loops in unit test environment
- Update package.json and package-lock.json dependencies - Update getGrantedAccess to support bulkOnly filter - Update test configurations for bulk processing support - Update e2e tests for grantAccess and getGrantedAccess
- Remove pricePerAccess and volume parameters from createBulkOrder call in grantAccess - Keep createBulkOrder function simple with infinite volume and zero price - Fix TypeScript compilation error
- Fix TypeScript error in processBulkRequest unit tests - Update mock to return Record<number, string> instead of string - Add proper Jest typing for pushRequesterSecret mock function
- Apply Prettier formatting to Jest mock function - Break long mock function call into multiple lines for better readability
PierreJeanjacquot
force-pushed
the
feat/add-bulk-processing-support
branch
from
58fa9ea to
9673f36
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds bulk processing functionality to the DataProtector SDK, enabling efficient processing of multiple protected data items in batch operations. The implementation introduces new APIs for preparing and executing bulk requests while maintaining backward compatibility.
Key changes:
- Added
prepareBulkRequest()andprocessBulkRequest()methods to handle bulk data processing workflows - Enhanced
grantAccess()with anallowBulkparameter to create bulk-compatible access grants - Added
bulkOnlyfilter togetGrantedAccess()for retrieving bulk-specific access grants
Reviewed Changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
packages/sdk/src/lib/dataProtectorCore/prepareBulkRequest.ts |
New module implementing bulk request preparation with encryption, secrets management, and dataset bulk creation |
packages/sdk/src/lib/dataProtectorCore/processBulkRequest.ts |
New module executing bulk requests with order matching, task creation, and result retrieval |
packages/sdk/src/lib/dataProtectorCore/grantAccess.ts |
Enhanced to support bulk access grants with infinite volume and zero pricing |
packages/sdk/src/lib/dataProtectorCore/getGrantedAccess.ts |
Added filtering capability for bulk-only access grants |
packages/sdk/src/lib/types/coreTypes.ts |
Added comprehensive type definitions for bulk processing APIs |
packages/sdk/src/utils/validators.ts |
Added validation schema for bulk request structure |
packages/sdk/src/lib/dataProtectorCore/processProtectedData.ts |
Refactored validation order and error handling; standardized tag usage |
packages/sdk/package.json |
Updated dependencies: iexec to 8.22.0, kubo-rpc-client to 5.4.1 |
packages/sdk/tests/docker-compose.yml |
Updated market-api image to version 7.1.0 |
| Test files | Added comprehensive unit and e2e tests; updated existing tests with defaultWorkerpool parameter |
Files not reviewed (1)
- packages/sdk/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/sdk/tests/unit/dataProtectorCore/processBulkRequest.test.ts
Outdated
Show resolved
Hide resolved
PierreJeanjacquot
approved these changes
Nov 4, 2025
PierreJeanjacquot
changed the title
abbesBenayache
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces comprehensive bulk processing capabilities for the DataProtector SDK, enabling efficient processing of multiple protected data orders simultaneously.
Key Features Added:
Technical Implementation:
The bulk processing system uses a sophisticated approach where a single request order represents the entire bulk operation, while multiple deals are created by matching with different workerpool orders until the target volume is achieved.