Limit number of shadow casting lights in ogre2 #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-rendering2 #155 +/- ##
==================================================
- Coverage 51.42% 51.39% -0.04%
==================================================
Files 117 117
Lines 10078 10088 +10
==================================================
+ Hits 5183 5185 +2
- Misses 4895 4903 +8
Continue to review full report at Codecov.
|
chapulina
approved these changes
Oct 1, 2020
Signed-off-by: Ian Chen <[email protected]>
chapulina
approved these changes
Oct 1, 2020
|
Is this actually somehow discussed with OGRE people? It seems that 25 light sources is pretty easy to get with the numbers of robots allowed... |
|
Not yet. I should check to see if it's still an issue in the latest version of OGRE 2.x. It's probably rare for games to have that many shadows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was found that when the number of shadow casting lights exceed a certain number, the dynamically generated shaders produce a compile error that suggests it's reached the max number of uniform variables allowed. This causes an rendering issue where parts of the scene becomes dark. So the workaround here is to put a hard limit on the max number of lights allowed in ogre2.
Here's a max_shadows.sdf world file with lights for testing. Before the fix, the model in the world will be dark and you'll see the compiler error in
~/.ignition/rendering/ogre2.log. After the fix, the model should render fine.Signed-off-by: Ian Chen [email protected]