Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ionic-team/ionic-framework
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v8.5.4
Choose a base ref
...
head repository: ionic-team/ionic-framework
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v8.5.5
Choose a head ref
  • 11 commits
  • 144 files changed
  • 7 contributors

Commits on Apr 9, 2025

  1. Configuration menu
    Copy the full SHA
    fd4ffdd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    51de007 View commit details
    Browse the repository at this point in the history
  3. merge release-8.5.4 (#30347)

    v8.5.4
    brandyscarney authored Apr 9, 2025
    Configuration menu
    Copy the full SHA
    1bc4f59 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2025

  1. fix(toggle): ensure proper visual selection when navigating via Voice…

    …Over in Safari (#30349)
    
    Issue number: resolves internal
    
    ---------
    
    <!-- Please do not submit updates to dependencies unless it fixes an
    issue. -->
    
    <!-- Please try to limit your pull request to one type (bugfix, feature,
    etc). Submit multiple pull requests if needed. -->
    
    ## What is the current behavior?
    <!-- Please describe the current behavior that you are modifying. -->
    Currently, MacOS voice over on Safari does not recognize ion-toggle
    correctly and fails to highlight the element properly
    
    ## What is the new behavior?
    <!-- Please describe the behavior or changes that are being added by
    this PR. -->
    
    By adding the role property to the host element, we're correctly
    identifying the toggle so Safari knows how to handle it.
    
    ## Does this introduce a breaking change?
    
    - [ ] Yes
    - [X] No
    
    <!--
      If this introduces a breaking change:
    1. Describe the impact and migration path for existing applications
    below.
      2. Update the BREAKING.md file with the breaking change.
    3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
    See
    https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer
    for more information.
    -->
    
    
    ## Other information
    
    <!-- Any other information that is important to this PR such as
    screenshots of how the component looks before and after the change. -->
    ShaneK authored Apr 11, 2025
    Configuration menu
    Copy the full SHA
    b1bc58f View commit details
    Browse the repository at this point in the history
  2. chore(deps): update dependency @capacitor/core to v7.2.0 (#30336)

    This PR contains the following updates:
    
    | Package | Change | Age | Adoption | Passing | Confidence |
    |---|---|---|---|---|---|
    | [@capacitor/core](https://capacitorjs.com)
    ([source](https://redirect.github.com/ionic-team/capacitor)) | [`7.1.0`
    ->
    `7.2.0`](https://renovatebot.com/diffs/npm/@capacitor%2fcore/7.1.0/7.2.0)
    |
    [![age](https://developer.mend.io/api/mc/badges/age/npm/@capacitor%2fcore/7.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
    |
    [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@capacitor%2fcore/7.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
    |
    [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@capacitor%2fcore/7.1.0/7.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
    |
    [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@capacitor%2fcore/7.1.0/7.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
    |
    
    ---
    
    ### Release Notes
    
    <details>
    <summary>ionic-team/capacitor (@&#8203;capacitor/core)</summary>
    
    ###
    [`v7.2.0`](https://redirect.github.com/ionic-team/capacitor/blob/HEAD/CHANGELOG.md#720-2025-03-31)
    
    [Compare
    Source](https://redirect.github.com/ionic-team/capacitor/compare/7.1.0...7.2.0)
    
    ##### Bug Fixes
    
    - **android:** rename bridge layout to avoid collision
    ([#&#8203;7919](https://redirect.github.com/ionic-team/capacitor/issues/7919))
    ([a629f16](https://redirect.github.com/ionic-team/capacitor/commit/a629f167b345cda1c44f37131235d14353eff504))
    - **cli:** Don't migrate Podfile on SPM projects
    ([#&#8203;7939](https://redirect.github.com/ionic-team/capacitor/issues/7939))
    ([ab4e700](https://redirect.github.com/ionic-team/capacitor/commit/ab4e700035289f445668dfd2f86278ffc71ab269))
    - **ios:** respect shouldEncodeUrlParams value
    ([#&#8203;7931](https://redirect.github.com/ionic-team/capacitor/issues/7931))
    ([4fb12a0](https://redirect.github.com/ionic-team/capacitor/commit/4fb12a03a92c0f38b0d48b114252342f4bdc17bf))
    
    ##### Features
    
    - **http:** Apply overrideUserAgent to requests
    ([#&#8203;7906](https://redirect.github.com/ionic-team/capacitor/issues/7906))
    ([52482c9](https://redirect.github.com/ionic-team/capacitor/commit/52482c9d3c575b737054b41f9d1730c70cc5f471))
    - **ios:** Enable Fullscreen API on WebView
    ([#&#8203;7909](https://redirect.github.com/ionic-team/capacitor/issues/7909))
    ([172638e](https://redirect.github.com/ionic-team/capacitor/commit/172638ec7b6eb67bf25f8dac2818122ba31c2c91))
    
    </details>
    
    ---
    
    ### Configuration
    
    📅 **Schedule**: Branch creation - "every weekday before 11am" (UTC),
    Automerge - At any time (no schedule defined).
    
    🚦 **Automerge**: Disabled by config. Please merge this manually once you
    are satisfied.
    
    ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox.
    
    🔕 **Ignore**: Close this PR and you won't be reminded about this update
    again.
    
    ---
    
    - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
    this box
    
    ---
    
    This PR was generated by [Mend Renovate](https://mend.io/renovate/).
    View the [repository job
    log](https://developer.mend.io/github/ionic-team/ionic-framework).
    
    <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yMjcuMyIsInVwZGF0ZWRJblZlciI6IjM5LjIyNy4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
    
    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Apr 11, 2025
    Configuration menu
    Copy the full SHA
    396ff3d View commit details
    Browse the repository at this point in the history
  3. chore(deps): update dependency node to v22 (#30326)

    This PR contains the following updates:
    
    | Package | Type | Update | Change |
    |---|---|---|---|
    | [node](https://redirect.github.com/actions/node-versions) | uses-with
    | major | `20.x` -> `22.x` |
    
    ---
    
    ### Release Notes
    
    <details>
    <summary>actions/node-versions (node)</summary>
    
    ###
    [`v22.14.0`](https://redirect.github.com/actions/node-versions/releases/tag/22.14.0-13265982013):
    22.14.0
    
    [Compare
    Source](https://redirect.github.com/actions/node-versions/compare/22.13.1-12900459766...22.14.0-13265982013)
    
    Node.js 22.14.0
    
    ###
    [`v22.13.1`](https://redirect.github.com/actions/node-versions/releases/tag/22.13.1-12900459766):
    22.13.1
    
    [Compare
    Source](https://redirect.github.com/actions/node-versions/compare/22.13.0-12671059536...22.13.1-12900459766)
    
    Node.js 22.13.1
    
    ###
    [`v22.13.0`](https://redirect.github.com/actions/node-versions/releases/tag/22.13.0-12671059536):
    22.13.0
    
    [Compare
    Source](https://redirect.github.com/actions/node-versions/compare/22.12.0-12152383658...22.13.0-12671059536)
    
    Node.js 22.13.0
    
    ###
    [`v22.12.0`](https://redirect.github.com/actions/node-versions/releases/tag/22.12.0-12152383658):
    22.12.0
    
    [Compare
    Source](https://redirect.github.com/actions/node-versions/compare/22.11.0-11593095476...22.12.0-12152383658)
    
    Node.js 22.12.0
    
    ###
    [`v22.11.0`](https://redirect.github.com/actions/node-versions/releases/tag/22.11.0-11593095476):
    22.11.0
    
    [Compare
    Source](https://redirect.github.com/actions/node-versions/compare/22.10.0-11377615849...22.11.0-11593095476)
    
    Node.js 22.11.0
    
    ###
    [`v22.10.0`](https://redirect.github.com/actions/node-versions/releases/tag/22.10.0-11377615849):
    22.10.0
    
    [Compare
    Source](https://redirect.github.com/actions/node-versions/compare/22.9.0-10914884886...22.10.0-11377615849)
    
    Node.js 22.10.0
    
    ###
    [`v22.9.0`](https://redirect.github.com/actions/node-versions/releases/tag/22.9.0-10914884886):
    22.9.0
    
    [Compare
    Source](https://redirect.github.com/actions/node-versions/compare/22.8.0-10685632420...22.9.0-10914884886)
    
    Node.js 22.9.0
    
    ###
    [`v22.8.0`](https://redirect.github.com/actions/node-versions/releases/tag/22.8.0-10685632420):
    22.8.0
    
    [Compare
    Source](https://redirect.github.com/actions/node-versions/compare/22.7.0-10511334152...22.8.0-10685632420)
    
    Node.js 22.8.0
    
    ###
    [`v22.7.0`](https://redirect.github.com/actions/node-versions/releases/tag/22.7.0-10511334152):
    22.7.0
    
    [Compare
    Source](https://redirect.github.com/actions/node-versions/compare/22.6.0-10277432289...22.7.0-10511334152)
    
    Node.js 22.7.0
    
    ###
    [`v22.6.0`](https://redirect.github.com/actions/node-versions/releases/tag/22.6.0-10277432289):
    22.6.0
    
    [Compare
    Source](https://redirect.github.com/actions/node-versions/compare/22.5.1-10010673511...22.6.0-10277432289)
    
    Node.js 22.6.0
    
    ###
    [`v22.5.1`](https://redirect.github.com/actions/node-versions/releases/tag/22.5.1-10010673511):
    22.5.1
    
    [Compare
    Source](https://redirect.github.com/actions/node-versions/compare/22.5.0-9985144103...22.5.1-10010673511)
    
    Node.js 22.5.1
    
    ###
    [`v22.5.0`](https://redirect.github.com/actions/node-versions/releases/tag/22.5.0-9985144103):
    22.5.0
    
    [Compare
    Source](https://redirect.github.com/actions/node-versions/compare/22.4.1-9860948056...22.5.0-9985144103)
    
    Node.js 22.5.0
    
    ###
    [`v22.4.1`](https://redirect.github.com/actions/node-versions/releases/tag/22.4.1-9860948056):
    22.4.1
    
    [Compare
    Source](https://redirect.github.com/actions/node-versions/compare/22.4.0-9766506602...22.4.1-9860948056)
    
    Node.js 22.4.1
    
    ###
    [`v22.4.0`](https://redirect.github.com/actions/node-versions/releases/tag/22.4.0-9766506602):
    22.4.0
    
    [Compare
    Source](https://redirect.github.com/actions/node-versions/compare/22.3.0-9569309553...22.4.0-9766506602)
    
    Node.js 22.4.0
    
    ###
    [`v22.3.0`](https://redirect.github.com/actions/node-versions/releases/tag/22.3.0-9569309553):
    22.3.0
    
    [Compare
    Source](https://redirect.github.com/actions/node-versions/compare/22.2.0-9105861751...22.3.0-9569309553)
    
    Node.js 22.3.0
    
    ###
    [`v22.2.0`](https://redirect.github.com/actions/node-versions/releases/tag/22.2.0-9105861751):
    22.2.0
    
    [Compare
    Source](https://redirect.github.com/actions/node-versions/compare/22.1.0-8926142033...22.2.0-9105861751)
    
    Node.js 22.2.0
    
    ###
    [`v22.1.0`](https://redirect.github.com/actions/node-versions/releases/tag/22.1.0-8926142033):
    22.1.0
    
    [Compare
    Source](https://redirect.github.com/actions/node-versions/compare/22.0.0-8879734543...22.1.0-8926142033)
    
    Node.js 22.1.0
    
    ###
    [`v22.0.0`](https://redirect.github.com/actions/node-versions/releases/tag/22.0.0-8879734543):
    22.0.0
    
    [Compare
    Source](https://redirect.github.com/actions/node-versions/compare/20.19.0-13838090974...22.0.0-8879734543)
    
    Node.js 22.0.0
    
    </details>
    
    ---
    
    ### Configuration
    
    📅 **Schedule**: Branch creation - "every weekday before 11am" (UTC),
    Automerge - At any time (no schedule defined).
    
    🚦 **Automerge**: Disabled by config. Please merge this manually once you
    are satisfied.
    
    ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox.
    
    🔕 **Ignore**: Close this PR and you won't be reminded about this update
    again.
    
    ---
    
    - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
    this box
    
    ---
    
    This PR was generated by [Mend Renovate](https://mend.io/renovate/).
    View the [repository job
    log](https://developer.mend.io/github/ionic-team/ionic-framework).
    
    <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yMjcuMyIsInVwZGF0ZWRJblZlciI6IjM5LjIyNy4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
    
    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Apr 11, 2025
    Configuration menu
    Copy the full SHA
    e1a4512 View commit details
    Browse the repository at this point in the history
  4. chore(deps): update dependency @clack/prompts to v0.10.1 (#30351)

    This PR contains the following updates:
    
    | Package | Change | Age | Adoption | Passing | Confidence |
    |---|---|---|---|---|---|
    |
    [@clack/prompts](https://redirect.github.com/bombshell-dev/clack/tree/main/packages/prompts#readme)
    ([source](https://redirect.github.com/bombshell-dev/clack/tree/HEAD/packages/prompts))
    | [`0.10.0` ->
    `0.10.1`](https://renovatebot.com/diffs/npm/@clack%2fprompts/0.10.0/0.10.1)
    |
    [![age](https://developer.mend.io/api/mc/badges/age/npm/@clack%2fprompts/0.10.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
    |
    [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@clack%2fprompts/0.10.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
    |
    [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@clack%2fprompts/0.10.0/0.10.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
    |
    [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@clack%2fprompts/0.10.0/0.10.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
    |
    
    ---
    
    ### Release Notes
    
    <details>
    <summary>bombshell-dev/clack (@&#8203;clack/prompts)</summary>
    
    ###
    [`v0.10.1`](https://redirect.github.com/bombshell-dev/clack/releases/tag/%40clack/prompts%400.10.1)
    
    [Compare
    Source](https://redirect.github.com/bombshell-dev/clack/compare/@clack/[email protected]...@clack/[email protected])
    
    ##### Patch Changes
    
    -
    [`11a5dc1`](https://redirect.github.com/bombshell-dev/clack/commit/11a5dc1):
    Fixes multiselect only shows hints on the first item in the options
    list. Now correctly shows hints for all selected options with hint
    property.
    -
    [`30aa7ed`](https://redirect.github.com/bombshell-dev/clack/commit/30aa7ed):
    Adds a new `selectableGroups` boolean to the group multi-select prompt.
    Using `selectableGroups: false` will disable the ability to select a
    top-level group, but still allow every child to be selected
    individually.
    - Updated dependencies
    \[[`30aa7ed`](https://redirect.github.com/bombshell-dev/clack/commit/30aa7ed)]
    - Updated dependencies
    \[[`5dfce8a`](https://redirect.github.com/bombshell-dev/clack/commit/5dfce8a)]
    - Updated dependencies
    \[[`f574297`](https://redirect.github.com/bombshell-dev/clack/commit/f574297)]
    -
    [@&#8203;clack/core](https://redirect.github.com/clack/core)[@&#8203;0](https://redirect.github.com/0).4.2
    
    </details>
    
    ---
    
    ### Configuration
    
    📅 **Schedule**: Branch creation - "every weekday before 11am" (UTC),
    Automerge - At any time (no schedule defined).
    
    🚦 **Automerge**: Disabled by config. Please merge this manually once you
    are satisfied.
    
    ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox.
    
    🔕 **Ignore**: Close this PR and you won't be reminded about this update
    again.
    
    ---
    
    - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
    this box
    
    ---
    
    This PR was generated by [Mend Renovate](https://mend.io/renovate/).
    View the [repository job
    log](https://developer.mend.io/github/ionic-team/ionic-framework).
    
    <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yMzguMCIsInVwZGF0ZWRJblZlciI6IjM5LjIzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
    
    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Apr 11, 2025
    Configuration menu
    Copy the full SHA
    44efdb0 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2025

  1. fix(modal): add expandToScroll property to ModalOptions (#30357)

    Issue number: resolves #30356
    
    ---------
    
    <!-- Please do not submit updates to dependencies unless it fixes an
    issue. -->
    
    <!-- Please try to limit your pull request to one type (bugfix, feature,
    etc). Submit multiple pull requests if needed. -->
    
    ## What is the current behavior?
    Cannot use expandToScroll property in ModalController.create
    
    ## What is the new behavior?
    ExpandToScroll can be added without syntax problems
    
    ## Does this introduce a breaking change?
    
    - [ ] Yes
    - [x] No
    luisbytes authored Apr 14, 2025
    Configuration menu
    Copy the full SHA
    8dd566b View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2025

  1. fix(config): allow LogLevel to work with isolatedModules and update a…

    …ll warns and errors to respect logLevel (#30350)
    
    Issue number: internal
    
    ---------
    
    ## What is the current behavior?
    - `LogLevel` throws error `Error: Cannot access ambient const enums when
    'isolatedModules' is enabled`
    - Several existing console warns and errors are not calling the function
    that respects the `logLevel` config
    
    ## What is the new behavior?
    - Remove `const` from the `enum` to work with `isolatedModules`
    - Update `console.warn`s to `printIonWarning`
    - Update `console.error`s to `printIonError`
    
    ## Does this introduce a breaking change?
    - [ ] Yes
    - [x] No
    
    ## Other information
    
    Dev build: `8.5.5-dev.11744729748.174bf7e0`
    
    ---------
    
    Co-authored-by: Brandy Smith <[email protected]>
    brandyscarney and brandyscarney authored Apr 16, 2025
    Configuration menu
    Copy the full SHA
    d52fca0 View commit details
    Browse the repository at this point in the history
  2. fix(select): update icon color and use correct focused class (#30342)

    Issue number: internal
    
    ---------
    
    <!-- Please do not submit updates to dependencies unless it fixes an
    issue. -->
    
    <!-- Please try to limit your pull request to one type (bugfix, feature,
    etc). Submit multiple pull requests if needed. -->
    
    ## What is the current behavior?
    <!-- Please describe the current behavior that you are modifying. -->
    
    There are a few items to note:
    - Styles are using a non-existing focus class. It currently uses
    `.has-focus` which isn't being used anywhere within `select.tsx`. It
    seems that `.has-focus` comes a copy and paste that wasn't updated.
    - Icon uses the highlight color when expanded, in item, and no fill.
    This leads to the styling looking weird compared to when it's not in an
    item especially since labels do not change colors. Only applies to `md`
    mode.
    
    | List no lines | List with lines |
    | --- | ----------- |
    | ![Screenshot 2025-04-07 at 1 01
    14 PM](https://github.com/user-attachments/assets/e310e5e8-d0bc-4976-b623-c8db358307c8)
    | ![Screenshot 2025-04-07 at 1 01
    31 PM](https://github.com/user-attachments/assets/d4c0776d-cd5d-48a1-95a3-42b74e3dd767)
    |
    
    - The focus without a validation status does not update the border
    correctly when inside an item and has a solid fill. Only applies to `md`
    mode.
    
    | Outside item | Inside item |
    |--------|--------|
    | ![Screenshot 2025-04-07 at 1 07
    13 PM](https://github.com/user-attachments/assets/ee8c4fff-630d-4f7c-b3c5-f9daf22ff7d4)
    | ![Screenshot 2025-04-07 at 1 08
    45 PM](https://github.com/user-attachments/assets/046d69fc-823e-4fa4-a19f-f8e641874b4d)
    |
    
    ## What is the new behavior?
    <!-- Please describe the behavior or changes that are being added by
    this PR. -->
    
    - Styles are now using the correct focus class: `.has-focus`, removing
    `ion-focused`.
    - If the select is inside an item and has no fill then the icon will not
    use the highlight color. Only applies to `md` mode.
    
    
    | List no lines | List with lines |
    | --- | ----------- |
    | ![Screenshot 2025-04-07 at 1 13
    17 PM](https://github.com/user-attachments/assets/0e6fd28e-4925-4799-a24b-8e21348eb168)
    | ![Screenshot 2025-04-07 at 1 14
    11 PM](https://github.com/user-attachments/assets/adec2576-27d9-4150-8e60-8af5fa9cc012)
    |
    
    - The focus without a validation status uses the highlight color when
    inside an item and has a solid fill. Only applies to `md` mode.
    
    | Outside item | Inside item |
    |--------|--------|
    | ![Screenshot 2025-04-07 at 1 07
    13 PM](https://github.com/user-attachments/assets/ee8c4fff-630d-4f7c-b3c5-f9daf22ff7d4)
    | ![Screenshot 2025-04-07 at 1 16
    47 PM](https://github.com/user-attachments/assets/bc8b03b9-6ad1-40b0-a7fd-3f6e654ec066)
    |
    
    ## Does this introduce a breaking change?
    
    - [ ] Yes
    - [x] No
    
    <!--
      If this introduces a breaking change:
    1. Describe the impact and migration path for existing applications
    below.
      2. Update the BREAKING.md file with the breaking change.
    3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
    See
    https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer
    for more information.
    -->
    
    
    ## Other information
    
    <!-- Any other information that is important to this PR such as
    screenshots of how the component looks before and after the change. -->
    
    Dev build: `8.5.4-dev.11744743162.1ec9251d`
    
    Select cannot have a focused class and an expanded class at the same
    time. It's one or the other.
    
    ---------
    
    Co-authored-by: Brandy Smith <[email protected]>
    thetaPC and brandyscarney authored Apr 16, 2025
    Configuration menu
    Copy the full SHA
    cad1c61 View commit details
    Browse the repository at this point in the history
  3. v8.5.5

    Ionitron committed Apr 16, 2025
    Configuration menu
    Copy the full SHA
    c5c4d1d View commit details
    Browse the repository at this point in the history
Loading