fix: code review

Author: vasco-santos

package.json

@@ -72,7 +72,7 @@
     "form-data": "^2.3.3",
     "hat": "0.0.3",
     "interface-ipfs-core": "~0.96.0",
-    "ipfsd-ctl": "~0.40.2",
+    "ipfsd-ctl": "~0.41.0",
     "ncp": "^2.0.0",
     "qs": "^6.5.2",
     "rimraf": "^2.6.2",
@@ -128,7 +128,7 @@
     "joi": "^14.3.0",
     "joi-browser": "^13.4.0",
     "joi-multiaddr": "^4.0.0",
-    "libp2p": "~0.24.3",
+    "libp2p": "libp2p/js-libp2p#master",
     "libp2p-bootstrap": "~0.9.3",
     "libp2p-crypto": "~0.16.0",
     "libp2p-kad-dht": "~0.14.4",

src/cli/commands/daemon.js

@@ -22,10 +22,6 @@ module.exports = {
         type: 'boolean',
         default: false
       })
-      .option('enable-dht-experiment', {
-        type: 'boolean',
-        default: false
-      })
       .option('offline', {
         desc: 'Run offline. Do not connect to the rest of the network but provide local API.',
         default: false

src/cli/commands/dht/find-peer.js

@@ -14,7 +14,9 @@ module.exports = {
       const peers = await ipfs.dht.findPeer(peerID)
       const addresses = peers.multiaddrs.toArray().map((ma) => ma.toString())
 
-      print(addresses)
+      addresses.forEach((addr) => {
+        print(addr)
+      })
     })())
   }
 }

src/cli/commands/dht/provide.js

@@ -13,11 +13,13 @@ module.exports = {
     }
   },
 
-  handler ({ ipfs, key, resolve }) {
-    // TODO add recursive option
+  handler ({ ipfs, key, recursive, resolve }) {
+    const opts = {
+      recursive
+    }
 
     resolve((async () => {
-      await ipfs.dht.provide(key)
+      await ipfs.dht.provide(key, opts)
     })())
   }
 }

src/core/components/dht.js

@@ -6,7 +6,8 @@ const PeerId = require('peer-id')
 const PeerInfo = require('peer-info')
 const CID = require('cids')
 const each = require('async/each')
-const setImmediate = require('async/setImmediate')
+const nextTick = require('async/nextTick')
+
 const errcode = require('err-code')
 
 const debug = require('debug')
@@ -38,7 +39,7 @@ module.exports = (self) => {
         } catch (err) {
           log.error(err)
 
-          return setImmediate(() => callback(errcode(err, 'ERR_INVALID_CID')))
+          return nextTick(() => callback(errcode(err, 'ERR_INVALID_CID')))
         }
       }
 
@@ -64,7 +65,7 @@ module.exports = (self) => {
         } catch (err) {
           log.error(err)
 
-          return setImmediate(() => callback(errcode(err, 'ERR_INVALID_CID')))
+          return nextTick(() => callback(errcode(err, 'ERR_INVALID_CID')))
         }
       }
 
@@ -95,7 +96,7 @@ module.exports = (self) => {
         } catch (err) {
           log.error(err)
 
-          return setImmediate(() => callback(errcode(err, 'ERR_INVALID_CID')))
+          return nextTick(() => callback(errcode(err, 'ERR_INVALID_CID')))
         }
       }
 

src/core/components/libp2p.js

@@ -77,7 +77,10 @@ function defaultBundle ({ datastore, peerInfo, peerBook, options, config }) {
       },
       dht: {
         kBucketSize: get(options, 'dht.kBucketSize', 20),
-        enabledDiscovery: get(options, 'dht.enabledDiscovery', true),
+        enabled: get(options, 'dht.enabled', true) && !(get(options, 'offline', false)),
+        randomWalk: {
+          enabled: get(options, 'dht.randomWalk.enabled', true)
+        },
         validators: {
           ipns: ipnsUtils.validator
         },
@@ -86,7 +89,6 @@ function defaultBundle ({ datastore, peerInfo, peerBook, options, config }) {
         }
       },
       EXPERIMENTAL: {
-        dht: !(get(options, 'local', false)),
         pubsub: get(options, 'EXPERIMENTAL.pubsub', false)
       }
     },

src/core/runtime/libp2p-browser.js

@@ -54,11 +54,9 @@ class Node extends libp2p {
           }
         },
         dht: {
-          kBucketSize: 20,
-          enabledDiscovery: true
+          enabled: false
         },
         EXPERIMENTAL: {
-          dht: true,
           pubsub: false
         }
       }

src/core/runtime/libp2p-nodejs.js

@@ -54,10 +54,12 @@ class Node extends libp2p {
         },
         dht: {
           kBucketSize: 20,
-          enabledDiscovery: true
+          enabled: true,
+          randomWalk: {
+            enabled: true
+          }
         },
         EXPERIMENTAL: {
-          dht: true,
           pubsub: false
         }
       }

src/http/api/resources/dht.js

@@ -144,7 +144,7 @@ exports.provide = {
         }).code(500)
       }
 
-      reply({})
+      reply()
     })
   }
 }
@@ -176,7 +176,7 @@ exports.put = {
         }).code(500)
       }
 
-      reply({})
+      reply()
     })
   }
 }

test/core/interface.spec.js

@@ -102,7 +102,7 @@ describe('interface-ipfs-core tests', function () {
 
   tests.name(CommonFactory.create({
     spawnOptions: {
-      args: ['--pass ipfs-is-awesome-software', '--local'],
+      args: ['--pass ipfs-is-awesome-software', '--offline'],
       initOptions: { bits: 512 },
       config: {
         Bootstrap: [],