Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: javaczhang/java-design-patterns
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: javaczhang/java-design-patterns
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: AmbassadorRefactoring
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 7 files changed
  • 1 contributor

Commits on Oct 15, 2018

  1. 1) Updated test cases to use Junit Assert method as compared to asser… 

    …t keyword 2) Proper testing of RemoteService using RandomProvider interface. Introduced RandomProvider interface so that randomness can be controlled from test cases. 3) For readability used constant for representing FAILURE
    @npathai
    npathai committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    ac3cdfb View commit details
    Browse the repository at this point in the history

  2. Addressing review comments, Deleting unintentional file and used FAIL… 

    …URE constant in ClientTest as well
    @npathai
    npathai committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    339dacc View commit details
    Browse the repository at this point in the history
Loading