Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: javaczhang/java-design-patterns
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: javaczhang/java-design-patterns
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: EventQueueRefactoring
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 4 files changed
  • 1 contributor

Commits on Oct 16, 2018

  1. 1) Test cases were not stopping AudioService before ending test case … 

    …2) Changed Audio to be a good singleton, previously because of Audio being bad singleton, test cases which were using static methods could have caused intermittent failures. 3) Made some other refactorings as well
    @npathai
    npathai committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    9bbb4da View commit details
    Browse the repository at this point in the history

  2. Removed sonar issue and converted Audio to eager singleton for simpli… 

    …city
    @npathai
    npathai committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    c0da4b3 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2018

  1. Updated class diagram PNG

    @npathai
    npathai committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    5a56b92 View commit details
    Browse the repository at this point in the history
Loading