Fixed Idea warnings

javadev · web-flow · commit c28bf8521321 · 2024-08-15T04:01:21.000+03:00
diff --git a/SECURITY.md b/SECURITY.md
@@ -3,7 +3,7 @@
 ## Supported Versions
 
 | Version | Supported          |
-| ------- | ------------------ |
+|---------|--------------------|
 | >= 1.70 | :white_check_mark: |
 | < 1.70  | :x:                |
 
diff --git a/pom.xml b/pom.xml
@@ -162,11 +162,13 @@
           </excludes>
         </configuration>
       </plugin>
+      <!--suppress MavenModelInspection -->
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-surefire-report-plugin</artifactId>
         <version>3.3.1</version>
       </plugin>
+      <!--suppress MavenModelInspection -->
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-jxr-plugin</artifactId>
@@ -181,6 +183,7 @@
           <includeTestSourceDirectory>true</includeTestSourceDirectory>
         </configuration>
       </plugin>
+      <!--suppress MavenModelInspection -->
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-pmd-plugin</artifactId>
@@ -203,11 +206,13 @@
           </rulesets>
         </configuration>
       </plugin>
+      <!--suppress MavenModelInspection -->
       <plugin>
         <groupId>com.github.spotbugs</groupId>
         <artifactId>spotbugs-maven-plugin</artifactId>
         <version>4.8.6.2</version>
       </plugin>
+      <!--suppress MavenModelInspection -->
       <plugin>
         <groupId>org.codehaus.mojo</groupId>
         <artifactId>taglist-maven-plugin</artifactId>
diff --git a/src/main/java/com/github/underscore/Json.java b/src/main/java/com/github/underscore/Json.java
@@ -695,22 +695,21 @@ private Number readNumber() {
             return result;
         }
 
-        private boolean readFraction() {
+        private void readFraction() {
             if (!readChar('.')) {
-                return false;
+                return;
             }
             if (!readDigit()) {
                 throw expected(DIGIT);
             }
             while (readDigit()) {
                 // ignored
             }
-            return true;
         }
 
-        private boolean readExponent() {
+        private void readExponent() {
             if (!readChar('e') && !readChar('E')) {
-                return false;
+                return;
             }
             if (!readChar('+')) {
                 readChar('-');
@@ -721,7 +720,6 @@ private boolean readExponent() {
             while (readDigit()) {
                 // ignored
             }
-            return true;
         }
 
         private boolean readChar(char ch) {
diff --git a/src/main/java/com/github/underscore/Underscore.java b/src/main/java/com/github/underscore/Underscore.java
@@ -1920,11 +1920,11 @@ public static List<Character> range(char start, char stop, int step) {
             return list;
         }
         if (start < stop) {
-            for (char value = start; value < stop; value += step) {
+            for (char value = start; value < stop; value += (char) step) {
                 list.add(value);
             }
         } else {
-            for (char value = start; value > stop; value += step) {
+            for (char value = start; value > stop; value += (char) step) {
                 list.add(value);
             }
         }
diff --git a/src/test/java/com/github/underscore/CollectionsTest.java b/src/test/java/com/github/underscore/CollectionsTest.java
@@ -53,6 +53,7 @@
  *
  * @author Valentyn Kolesnikov
  */
+@SuppressWarnings("java:S1186")
 class CollectionsTest {
 
     /*
@@ -1718,7 +1719,9 @@ public Integer next() {
                                 return array[index++];
                             }
 
-                            public void remove() {}
+                            @Override
+                            public void remove() {
+                            }
                         };
         assertEquals(6, Underscore.size(iterable));
         assertEquals(5, Underscore.size(new Integer[] {5, 4, 3, 2, 1}));
diff --git a/src/test/java/com/github/underscore/LodashTest.java b/src/test/java/com/github/underscore/LodashTest.java
@@ -616,20 +616,24 @@ void fetchGet() {
                         "https://support.oneskyapp.com/hc/en-us/article_attachments/202761627/example_1.json");
         result.json();
         result.jsonMap();
-        //        assertEquals("{\"gameId\":483159,\"knight\":{\"name\":"
-        //            + "\"Sir. Russell Jones of
-        // Alberta\",\"attack\":2,\"armor\":7,\"agility\":3,\"endurance\":8}}",
-        //            result.text());
-        //        assertEquals("Sir. Russell Jones of Alberta",
-        //            (String) Underscore.get((Map<String, Object>) result.json(), "knight.name"));
+                assertEquals("{\n"
+                                + "    \"fruit\": \"Apple\",\n"
+                                + "    \"size\": \"Large\",\n"
+                                + "    \"color\": \"Red\"\n"
+                                + "}",
+                    result.text());
+                assertEquals("Apple",
+                        U.get((Map<String, Object>) result.json(), "fruit"));
         U.Chain<?> resultChain =
                 U.chain(
                                 "https://support.oneskyapp.com/hc/en-us/article_attachments/202761627/example_1.json")
                         .fetch();
-        //        assertEquals("{\"gameId\":483159,\"knight\":{\"name\":"
-        //            + "\"Sir. Russell Jones of
-        // Alberta\",\"attack\":2,\"armor\":7,\"agility\":3,\"endurance\":8}}",
-        //            resultChain.item());
+                assertEquals("{\n"
+                                + "    \"fruit\": \"Apple\",\n"
+                                + "    \"size\": \"Large\",\n"
+                                + "    \"color\": \"Red\"\n"
+                                + "}",
+                    resultChain.item());
         U.chain(
                         "https://support.oneskyapp.com/hc/en-us/article_attachments/202761627/example_1.json")
                 .fetch();
@@ -662,10 +666,12 @@ void fetchGetWithTimeouts() {
                         "https://support.oneskyapp.com/hc/en-us/article_attachments/202761627/example_1.json",
                         30000,
                         30000);
-        //        assertEquals("{\"gameId\":483159,\"knight\":{\"name\":"
-        //            + "\"Sir. Russell Jones of
-        // Alberta\",\"attack\":2,\"armor\":7,\"agility\":3,\"endurance\":8}}",
-        //            result.text());
+                assertEquals("{\n"
+                                + "    \"fruit\": \"Apple\",\n"
+                                + "    \"size\": \"Large\",\n"
+                                + "    \"color\": \"Red\"\n"
+                                + "}",
+                    result.text());
     }
 
     @Test
@@ -725,9 +731,7 @@ void fetchPut() {
                                 + "        \"fireBreath\": 10"
                                 + "    }"
                                 + "}");
-        //        assertEquals("{\"status\":\"Victory\",\"message\":\"Dragon was successful in a
-        // glorious battle\"}",
-        //            result.text());
+                assertEquals(403, result.getStatus());
         U.FetchResponse result2 =
                 U.fetch(
                         "https://support.oneskyapp.com/hc/en-us/article_attachments/202761627/example_1.json",
@@ -743,10 +747,8 @@ void fetchPut() {
                         null,
                         null,
                         null);
-        //        assertEquals("{\"status\":\"Defeat\",\"message\":"
-        //            + "\"No dragon showed up, knight dealt his deeds as he pleased.\"}",
-        // result2.text());
-        U.Chain resultChain =
+        assertEquals(403, result2.getStatus());
+        U.Chain<String> resultChain =
                 U.chain(
                                 "http://support.oneskyapp.com/hc/en-us/article_attachments/202761627/example_1.json")
                         .fetch(
@@ -759,9 +761,13 @@ void fetchPut() {
                                         + "        \"fireBreath\": 10"
                                         + "    }"
                                         + "}");
-        //        assertEquals("{\"status\":\"Victory\",\"message\":\"Dragon was successful in a
-        // glorious battle\"}",
-        //            resultChain.item());
+        assertEquals("<html>\n"
+                + "<head><title>301 Moved Permanently</title></head>\n"
+                + "<body>\n"
+                + "<center><h1>301 Moved Permanently</h1></center>\n"
+                + "<hr><center>cloudflare</center>\n"
+                + "</body>\n"
+                + "</html>\n", resultChain.item().replace("\r\n", "\n"));
     }
 
     @Test
diff --git a/src/test/java/com/github/underscore/StringTest.java b/src/test/java/com/github/underscore/StringTest.java
@@ -3569,16 +3569,12 @@ void fromXmlStackoverflowObject() throws IOException {
     }
 
     private String repeat(String s, int times) {
-        StringBuilder stringBuilder = new StringBuilder(s.length() * times);
-        for (int i = 0; i < times; i++) {
-            stringBuilder.append(s);
-        }
-        return stringBuilder.toString();
+        return s.repeat(Math.max(0, times));
     }
 
     @SuppressWarnings("unchecked")
     @Test
-    void testParseDeeplyNestedArrays() throws IOException {
+    void testParseDeeplyNestedArrays() {
         int times = 1000;
         // [[[ ... ]]]
         String json = repeat("[", times) + repeat("]", times);
@@ -3598,7 +3594,7 @@ void testParseDeeplyNestedArrays() throws IOException {
 
     @SuppressWarnings("unchecked")
     @Test
-    void testParseDeeplyNestedObjects() throws IOException {
+    void testParseDeeplyNestedObjects() {
         int times = 1000;
         // {"a":{"a": ... {"a":null} ... }}
         String json = repeat("{\"a\":", times) + "null" + repeat("}", times);
diff --git a/src/test/java/com/github/underscore/UnderscoreTest.java b/src/test/java/com/github/underscore/UnderscoreTest.java
@@ -792,7 +792,7 @@ void testPropertiesToMapWithEmptyProperties() {
         Map<String, Object> map = U.propertiesToMap(properties);
         assertEquals(0, map.size());
         Map<String, Object> map2 = U.propertiesToMap(null);
-        assertEquals(0, map.size());
+        assertEquals(0, map2.size());
     }
 
     @Test

Original file line number	Diff line number	Diff line change
`@@ -695,22 +695,21 @@ private Number readNumber() {`
`695`	`695`	`return result;`
`696`	`696`	`}`
`697`	`697`
`698`		`- private boolean readFraction() {`
	`698`	`+ private void readFraction() {`
`699`	`699`	`if (!readChar('.')) {`
`700`		`- return false;`
	`700`	`+ return;`
`701`	`701`	`}`
`702`	`702`	`if (!readDigit()) {`
`703`	`703`	`throw expected(DIGIT);`
`704`	`704`	`}`
`705`	`705`	`while (readDigit()) {`
`706`	`706`	`// ignored`
`707`	`707`	`}`
`708`		`- return true;`
`709`	`708`	`}`
`710`	`709`
`711`		`- private boolean readExponent() {`
	`710`	`+ private void readExponent() {`
`712`	`711`	`if (!readChar('e') && !readChar('E')) {`
`713`		`- return false;`
	`712`	`+ return;`
`714`	`713`	`}`
`715`	`714`	`if (!readChar('+')) {`
`716`	`715`	`readChar('-');`
`@@ -721,7 +720,6 @@ private boolean readExponent() {`
`721`	`720`	`while (readDigit()) {`
`722`	`721`	`// ignored`
`723`	`722`	`}`
`724`		`- return true;`
`725`	`723`	`}`
`726`	`724`
`727`	`725`	`private boolean readChar(char ch) {`
Original file line number	Diff line number	Diff line change
`@@ -1920,11 +1920,11 @@ public static List<Character> range(char start, char stop, int step) {`
`1920`	`1920`	`return list;`
`1921`	`1921`	`}`
`1922`	`1922`	`if (start < stop) {`
`1923`		`- for (char value = start; value < stop; value += step) {`
	`1923`	`+ for (char value = start; value < stop; value += (char) step) {`
`1924`	`1924`	`list.add(value);`
`1925`	`1925`	`}`
`1926`	`1926`	`} else {`
`1927`		`- for (char value = start; value > stop; value += step) {`
	`1927`	`+ for (char value = start; value > stop; value += (char) step) {`
`1928`	`1928`	`list.add(value);`
`1929`	`1929`	`}`
`1930`	`1930`	`}`
Original file line number	Diff line number	Diff line change
`@@ -792,7 +792,7 @@ void testPropertiesToMapWithEmptyProperties() {`
`792`	`792`	`Map<String, Object> map = U.propertiesToMap(properties);`
`793`	`793`	`assertEquals(0, map.size());`
`794`	`794`	`Map<String, Object> map2 = U.propertiesToMap(null);`
`795`		`- assertEquals(0, map.size());`
	`795`	`+ assertEquals(0, map2.size());`
`796`	`796`	`}`
`797`	`797`
`798`	`798`	`@Test`