Skip to content

Commit c10945d

Browse files
authored
Build: Remove obsolete globals from ESLint configuration
We had quite a few obsolete globals declared in various ESLint config files. We also no longer allow to rely on the `noGlobal` & `jQuery` globals in the built file which is not needed. Closes gh-4301
1 parent 8751e9e commit c10945d

File tree

3 files changed

+6
-11
lines changed

3 files changed

+6
-11
lines changed

.eslintrc-browser.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,8 @@
1919

2020
"globals": {
2121
"window": true,
22-
"jQuery": true,
2322
"define": true,
24-
"module": true,
25-
"noGlobal": true
23+
"module": true
2624
},
2725

2826
"rules": {

src/.eslintrc.json

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
{
22
"root": true,
33

4-
"extends": "../.eslintrc-browser.json"
4+
"extends": "../.eslintrc-browser.json",
5+
6+
"globals": {
7+
"jQuery": true
8+
}
59
}

test/.eslintrc.json

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,22 +12,15 @@
1212

1313
"globals": {
1414
"require": false,
15-
"define": false,
16-
"DOMParser": false,
17-
"JSON": false,
1815
"Promise": false,
1916
"Symbol": false,
2017
"QUnit": false,
2118
"ajaxTest": false,
2219
"testIframe": false,
23-
"testIframeWithCallback": false,
24-
"iframeCallback": true,
2520
"createDashboardXML": false,
2621
"createXMLFragment": false,
2722
"moduleTeardown": false,
28-
"testFoo": false,
2923
"url": false,
30-
"t": false,
3124
"q": false,
3225
"jQuery": true,
3326
"sinon": true,

0 commit comments

Comments
 (0)