Skip to content

Tree > Open a text file (or any editable file other than ipynb) > Blank page #2071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gnestor opened this issue Jan 25, 2017 · 4 comments · Fixed by #2073
Closed

Tree > Open a text file (or any editable file other than ipynb) > Blank page #2071

gnestor opened this issue Jan 25, 2017 · 4 comments · Fixed by #2073

Comments

@gnestor
Copy link
Contributor

gnestor commented Jan 25, 2017

This appears to be a regression in 4.2 or 4.2.1. Possibly related to 11bd42c.

https://github.com/jupyter/notebook/blob/master/notebook/static/edit/js/main.js#L46

 ReferenceError: contents is not defined     require.js?v=6da8be3…:900
    at main.js:46
    at Object.execCb (require.js?v=6da8be3…:1690)
    at Module.check (require.js?v=6da8be3…:865)
    at Module.<anonymous> (require.js?v=6da8be3…:1140)
    at require.js?v=6da8be3…:131
    at require.js?v=6da8be3…:1190
    at each (require.js?v=6da8be3…:56)
    at Module.emit (require.js?v=6da8be3…:1189)
    at Module.check (require.js?v=6da8be3…:940)
    at Module.enable (require.js?v=6da8be3…:1177)
@minrk
Copy link
Member

minrk commented Jan 25, 2017

That commit makes sense that it could cause such an error, but it wouldn't affect 4.2, since that commit is only in master. Can you see this error in a 4.2 release?

@gnestor
Copy link
Contributor Author

gnestor commented Jan 25, 2017

Yes, I only see this is master. I tried the 4.2 branch and it works as expected.

@minrk
Copy link
Member

minrk commented Jan 25, 2017

Mark as 5.0, not 4.3, then?

@gnestor gnestor modified the milestones: 5.0, 4.3.2 Jan 25, 2017
@minrk
Copy link
Member

minrk commented Jan 25, 2017

#2073 ought to do it.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants