-
Notifications
You must be signed in to change notification settings - Fork 383
Revamp our documentation and refactor a bit #1433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for more information, see https://pre-commit.ci
|
/cc @chuckwondo who has helped with related docs to take a look if he can :) |
chuckwondo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tagging me @yuvipanda.
@choldgraf, thanks for the reorg. Your description of the reorg sounds great, and I've added a few comments, but I haven't gone over it in great detail. If I could see it all properly rendered, it would be much easier to provide comments regarding the layout/reorg, and go through it all in detail. Is that possible without my having to pull it down and run the doc server locally?
|
@chuckwondo you can see it in https://repo2docker--1433.org.readthedocs.build/en/1433/! That link is accessible via the tests - it's the read the docs |
|
The latest PR adds a bit more content using some slides from a presentation that @yuvipanda has given a few times about repo2docker. Here are some highlights (copied to the PR body as well):
I think this is ready for somebody to take a pass at it - many thanks for the review @chuckwondo - I'll get to your questions when I take another pass after you or somebody else gives it a look. |
rgaiacs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great revamp of the documentation. I added minor comments. I'm happy for this to be merged and further improvement to be made in new pull requests.
for more information, see https://pre-commit.ci
|
I believe that I've addressed all of the comments except for a couple. I'm not sure whether we recommend "just" |
|
Yes, I can send a PR covering the use of "container image". |
|
Feel free to ping me and I'm happy to review. Shall we merge this one and then iterate there? |
Yes. 👍 to merge. |
|
OK cool - let's wait a couple hours to see if @chuckwondo wants to give another pass, but I think I addressed his questions, and given your review i think it's safe to merge. I'll merge if he doesn't ask us to hold off. Happy to iterate with y'all further |
chuckwondo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the reorg and the clarity! Thanks!
docs/source/index.md
Outdated
| follows the [Reproducible Executable Environment Specification](./specification.md). Repositories can be pulled from a number of repository providers, such as the URL of a Git repository, a [DOI](https://en.wikipedia.org/wiki/Digital_object_identifier) from Zenodo or Figshare, a [Handle](https://en.wikipedia.org/wiki/Handle_System) or DOI from a Dataverse installation, a [SWHID] of a directory of a revision archived in the | ||
| [Software Heritage Archive](https://archive.softwareheritage.org), or a path to a local directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider pulling these cases out into a bulleted list for better visibility/readability.
for more information, see https://pre-commit.ci
|
Thanks @chuckwondo for the extra comments - I've gone through and made another round of edits to address your suggestions. Thank you to both of you for your help. I'll merge this one in since we have one explicit and one implicit approval, and please ping me if y'all would like to iterate on the content more from here! |
This updates our documentation to make it a bit easier to navigate and understand. It also makes some content improvements along the way.
Docs preview of this PR is here
Here are some major things that this PR tries to improve:
get startedguide is now a tutorial, meant to be followed step by step, in line with how Diataxis recommends tutorials be used. It now has fewer information, and focuses specifically on "getting started"howtosection has been renamed theuser guide, and now groups pages based on major topic area (e.g.Configuration,Deployment, etc).datascience) to make it easier to parse.dirhtmlbuilder for "clean" URLs. If we merge this, we should enableclean URLswith readthedocs so that any direct links will properly redirectMore updates
It probably could use a pass or two to double check that the structure works and that I haven't missed something. Happy to iterate with feedback if folks would like.