Makefile modernization

[gstrauss]

Makefile modernization

• update optimization flags
• use Makefile patterns to reduce duplication
• remove -ansi flag (increase portability)
• add missing dependencies

fix compiler warnings

• const correctness
• format string safety
• remove assigned, but unused, variables
• fix arguments to execl()
• remove defined but unused warnings (for code used only by some tests)

remove declarations which dup from system headers

• ('-ansi' compiler flag might have caused some declarations to be hidden)

Includes and supercedes #31 :
Fix for OS X based on https://gist.github.com/barusan/11033924

Add .gitignore

[gstrauss]

Tested on Linux by @gstrauss (me).
Tested on OS X by @mihalis68

[kdlucas]

Tony,

Can you review this pull request?

[gstrauss]

@voellm: would you review this pull request? Thank you.

[gstrauss]

@voellm: would you review this pull request? Thank you.

[gstrauss]

@voellm: would you review this pull request? Thank you.

[gstrauss]

@voellm: would you review this pull request? Thank you.

@kdlucas: I'll wait another week for any sign of life, but after that I plan to contact github admins to break my fork from this project so that it can be maintained independently. It's been over a month of complete radio silence despite weekly requests for feedback.

[kdlucas]

I can do the review if you like. I'm not really well versed in it, but at
least that will let you get it checked in. We probably need to get another
person on the project to do code reviews and features if needed.

Kelly
kdLucas

On Wed, Apr 27, 2016 at 8:30 PM, Glenn Strauss [email protected]
wrote:

@voellm https://github.com/voellm: would you review this pull request?
Thank you.

@kdlucas https://github.com/kdlucas: I'll wait another week for any
sign of life, but after that I plan to contact github admins to break my
fork from this project so that it can be maintained independently. It's
been over a month of complete radio silence despite weekly requests for
feedback.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#34 (comment)

[gstrauss]

Thanks @kdlucas. I am a fan of (timely) code reviews and am happy to try to answer/explain any questions you might have related to the patches, such as why I chose to do things one way versus another way when there were multiple options. FYI: there are 5 separate commits in this pull request, done so that it would be easier to review each one in isolation.

[kdlucas]

Ok, I'll take a look over the next few days.

Kelly
kdLucas

On Wed, Apr 27, 2016 at 11:00 PM, Glenn Strauss [email protected]
wrote:

Thanks @kdlucas https://github.com/kdlucas. I am a fan of (timely) code
reviews and am happy to try to answer/explain any questions you might have
related to the patches, such as why I chose to do things one way versus
another way when there were multiple options. FYI: there are 5 separate
commits in this pull request, done so that it would be easier to review
each one in isolation.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#34 (comment)