Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kubernetes-sigs/controller-runtime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.18.0
Choose a base ref
...
head repository: kubernetes-sigs/controller-runtime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.18.2
Choose a head ref
  • 6 commits
  • 8 files changed
  • 4 contributors

Commits on May 1, 2024

  1. bug: Cache: Fix label defaulting of byObject when namespaces are conf…

    …igured
    
    Currently, if there are global namespaces configured and no per-object
    namesapces, while there is both a global and a per-object labelSelector,
    we will:
    1. Default the namespaces labelSelector from `DefaultLabelSelector`
    2. Copy the namespaces including config into `byObject.Namespaces`
    
    And thus end up with the global labelSelector overriding the per-object
    one, this change fixes that by swapping step 1 and 2.
    alvaroaleman authored and k8s-infra-cherrypick-robot committed May 1, 2024
    Configuration menu
    Copy the full SHA
    87cae4c View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2808 from k8s-infra-cherrypick-robot/cherry-pick-…

    …2805-to-release-0.18
    
    [release-0.18] 🐛 Cache: Fix label defaulting of byObject when namespaces are configured
    k8s-ci-robot authored May 1, 2024
    Configuration menu
    Copy the full SHA
    d6feaae View commit details
    Browse the repository at this point in the history
  3. 🐛 correct kind source type

    Reverse the nil check in the String function of the internal Kind source
    to print the type when known.
    
    Fixes: 2add01e ("Event, source, handler, predicates: Use generics")
    Signed-off-by: Terin Stock <[email protected]>
    terinjokes authored and k8s-infra-cherrypick-robot committed May 1, 2024
    Configuration menu
    Copy the full SHA
    06acde3 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #2809 from k8s-infra-cherrypick-robot/cherry-pick-…

    …2806-to-release-0.18
    
    [release-0.18] 🐛 correct kind source type
    k8s-ci-robot authored May 1, 2024
    Configuration menu
    Copy the full SHA
    cd2885e View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Reintroduce AddMetricsExtraHandler on manager

    Signed-off-by: Vince Prignano <[email protected]>
    vincepri authored and k8s-infra-cherrypick-robot committed May 6, 2024
    Configuration menu
    Copy the full SHA
    6396a49 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2817 from k8s-infra-cherrypick-robot/cherry-pick-…

    …2813-to-release-0.18
    
    [release-0.18] 🐛 Reintroduce AddMetricsServerExtraHandler on manager
    k8s-ci-robot authored May 6, 2024
    Configuration menu
    Copy the full SHA
    834905b View commit details
    Browse the repository at this point in the history
Loading