-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Comparing changes
Open a pull request
base repository: kubernetes-sigs/controller-runtime
base: v0.18.0
head repository: kubernetes-sigs/controller-runtime
compare: v0.18.2
- 6 commits
- 8 files changed
- 4 contributors
Commits on May 1, 2024
-
bug: Cache: Fix label defaulting of byObject when namespaces are conf…
…igured Currently, if there are global namespaces configured and no per-object namesapces, while there is both a global and a per-object labelSelector, we will: 1. Default the namespaces labelSelector from `DefaultLabelSelector` 2. Copy the namespaces including config into `byObject.Namespaces` And thus end up with the global labelSelector overriding the per-object one, this change fixes that by swapping step 1 and 2.
Configuration menu - View commit details
-
Copy full SHA for 87cae4c - Browse repository at this point
Copy the full SHA 87cae4cView commit details -
Merge pull request #2808 from k8s-infra-cherrypick-robot/cherry-pick-…
…2805-to-release-0.18 [release-0.18] 🐛 Cache: Fix label defaulting of byObject when namespaces are configured
Configuration menu - View commit details
-
Copy full SHA for d6feaae - Browse repository at this point
Copy the full SHA d6feaaeView commit details -
Reverse the nil check in the String function of the internal Kind source to print the type when known. Fixes: 2add01e ("Event, source, handler, predicates: Use generics") Signed-off-by: Terin Stock <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 06acde3 - Browse repository at this point
Copy the full SHA 06acde3View commit details -
Merge pull request #2809 from k8s-infra-cherrypick-robot/cherry-pick-…
…2806-to-release-0.18 [release-0.18] 🐛 correct kind source type
Configuration menu - View commit details
-
Copy full SHA for cd2885e - Browse repository at this point
Copy the full SHA cd2885eView commit details
Commits on May 6, 2024
-
Reintroduce AddMetricsExtraHandler on manager
Signed-off-by: Vince Prignano <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6396a49 - Browse repository at this point
Copy the full SHA 6396a49View commit details -
Merge pull request #2817 from k8s-infra-cherrypick-robot/cherry-pick-…
…2813-to-release-0.18 [release-0.18] 🐛 Reintroduce AddMetricsServerExtraHandler on manager
Configuration menu - View commit details
-
Copy full SHA for 834905b - Browse repository at this point
Copy the full SHA 834905bView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.18.0...v0.18.2