Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kubernetes-sigs/controller-tools
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.16.4
Choose a base ref
...
head repository: kubernetes-sigs/controller-tools
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.16.5
Choose a head ref
  • 13 commits
  • 10 files changed
  • 5 contributors

Commits on Oct 14, 2024

  1. 🌱 Bump actions/checkout in the all-github-actions group

    Bumps the all-github-actions group with 1 update: [actions/checkout](https://github.com/actions/checkout).
    
    
    Updates `actions/checkout` from 4.2.0 to 4.2.1
    - [Release notes](https://github.com/actions/checkout/releases)
    - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
    - [Commits](actions/checkout@d632683...eef6144)
    
    ---
    updated-dependencies:
    - dependency-name: actions/checkout
      dependency-type: direct:production
      update-type: version-update:semver-patch
      dependency-group: all-github-actions
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    c43bf15 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1075 from kubernetes-sigs/dependabot/github_actio…

    …ns/all-github-actions-a9bb80ae19
    
    🌱 Bump actions/checkout from 4.2.0 to 4.2.1 in the all-github-actions group
    k8s-ci-robot authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    d0b7b74 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. pkg/crd: support validation on type alias to basic types

    Without the type Alias being its own type (Go 1.22 see gotypesalias), in
    localNamedToSchema, the link is missing.
    
    [ Upstream port of cilium/controller-tools@d944debcff34 ("Support type
    aliasing to basic types") ]
    
    Previously, validation schema generation was skipped on a type alias:
    
    	type A = B
    
    Whereas, a new type was fine:
    
    	type A B
    
    This commit implements support for generating validation schemas for
    type aliases to basic types, i.e. string, int, etc.
    
    Co-authored-by: Chris Tarazi <[email protected]>
    Signed-off-by: Mahe Tardy <[email protected]>
    mtardy and christarazi committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    7587d2c View commit details
    Browse the repository at this point in the history
  2. pkg/crd: fix alias conversion to schema with gotypesalias=1

    This patch will be needed when upgrading to Go 1.23 as type alias now
    generate a proper type (instead of directly being the basic type they
    alias to), see https://pkg.go.dev/go/types#Alias for more info.
    
    This just reproduces the old behavior by retrieving the underlying type
    from the alias. If needed, we could treat alias more gracefully to make
    the type ref link now that we have all the type information.
    
    Signed-off-by: Mahe Tardy <[email protected]>
    mtardy committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    e443da3 View commit details
    Browse the repository at this point in the history
  3. pkg/crd: fix a missed type casting panic with new *types.Alias

    This is a follow up on 0a52475 ("pkg/crd: fix type casting panic
    with new default *types.Alias"). Look for the commit message of the
    cited commit for more context.
    
    Signed-off-by: Mahe Tardy <[email protected]>
    mtardy committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    fd3bd9f View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Merge pull request #1079 from mtardy/pr/mtardy/fix-exprsel-alias

    🐛 pkg/crd: fix a missed type casting panic with new *types.Alias
    k8s-ci-robot authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    5656666 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1078 from mtardy/pr/mtardy/type-alias-validation

    🐛 pkg/crd: support validation on type alias to basic types
    k8s-ci-robot authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    49ae6f8 View commit details
    Browse the repository at this point in the history
  3. Fix item validation for unhashable markers

    Signed-off-by: Stefan Büringer [email protected]
    sbueringer committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    79a0f50 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #1080 from sbueringer/pr-fix-items-enum

    🐛 Fix item validation for unhashable markers
    k8s-ci-robot authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    5ea1855 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. 🌱 Bump the all-go-mod-patch-and-minor group with 4 updates

    Bumps the all-go-mod-patch-and-minor group with 4 updates: [github.com/fatih/color](https://github.com/fatih/color), [k8s.io/api](https://github.com/kubernetes/api), [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) and [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery).
    
    
    Updates `github.com/fatih/color` from 1.17.0 to 1.18.0
    - [Release notes](https://github.com/fatih/color/releases)
    - [Commits](fatih/color@v1.17.0...v1.18.0)
    
    Updates `k8s.io/api` from 0.31.1 to 0.31.2
    - [Commits](kubernetes/api@v0.31.1...v0.31.2)
    
    Updates `k8s.io/apiextensions-apiserver` from 0.31.1 to 0.31.2
    - [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases)
    - [Commits](kubernetes/apiextensions-apiserver@v0.31.1...v0.31.2)
    
    Updates `k8s.io/apimachinery` from 0.31.1 to 0.31.2
    - [Commits](kubernetes/apimachinery@v0.31.1...v0.31.2)
    
    ---
    updated-dependencies:
    - dependency-name: github.com/fatih/color
      dependency-type: direct:production
      update-type: version-update:semver-minor
      dependency-group: all-go-mod-patch-and-minor
    - dependency-name: k8s.io/api
      dependency-type: direct:production
      update-type: version-update:semver-patch
      dependency-group: all-go-mod-patch-and-minor
    - dependency-name: k8s.io/apiextensions-apiserver
      dependency-type: direct:production
      update-type: version-update:semver-patch
      dependency-group: all-go-mod-patch-and-minor
    - dependency-name: k8s.io/apimachinery
      dependency-type: direct:production
      update-type: version-update:semver-patch
      dependency-group: all-go-mod-patch-and-minor
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    8aeb7d1 View commit details
    Browse the repository at this point in the history
  2. 🌱 Bump the all-github-actions group with 2 updates

    Bumps the all-github-actions group with 2 updates: [actions/checkout](https://github.com/actions/checkout) and [actions/setup-go](https://github.com/actions/setup-go).
    
    
    Updates `actions/checkout` from 4.2.1 to 4.2.2
    - [Release notes](https://github.com/actions/checkout/releases)
    - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
    - [Commits](actions/checkout@eef6144...11bd719)
    
    Updates `actions/setup-go` from 5.0.2 to 5.1.0
    - [Release notes](https://github.com/actions/setup-go/releases)
    - [Commits](actions/setup-go@0a12ed9...41dfa10)
    
    ---
    updated-dependencies:
    - dependency-name: actions/checkout
      dependency-type: direct:production
      update-type: version-update:semver-patch
      dependency-group: all-github-actions
    - dependency-name: actions/setup-go
      dependency-type: direct:production
      update-type: version-update:semver-minor
      dependency-group: all-github-actions
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    2e2e001 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #1082 from kubernetes-sigs/dependabot/go_modules/a…

    …ll-go-mod-patch-and-minor-9b8ee6b8a7
    
    🌱 Bump the all-go-mod-patch-and-minor group with 4 updates
    k8s-ci-robot authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    932f834 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #1083 from kubernetes-sigs/dependabot/github_actio…

    …ns/all-github-actions-240149f75d
    
    🌱 Bump the all-github-actions group with 2 updates
    k8s-ci-robot authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    23a31fd View commit details
    Browse the repository at this point in the history
Loading