Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kubernetes/git-sync
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.2.4
Choose a base ref
...
head repository: kubernetes/git-sync
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.3.0
Choose a head ref
  • 9 commits
  • 35 files changed
  • 5 contributors

Commits on Jul 16, 2024

  1. test: harden e2e image build logic

    This introduces several changes to make the e2e test image logic more
    robust:
    
    - Rename IMAGE to GIT_SYNC_E2E_IMAGE to minimize accidental misuse
    - Ensure that the image built by make container is the same as the image
      used by docker run
    - Do not build the container if a custom image is specified
    
    As an example, with the prior logic the following command always fails:
    IMAGE="" make test
    ...
    Unable to find image 'gcr.io/k8s-staging-git-sync/git-sync:latest' locally
    
    Because the docker run command pulls a different image from the one
    built by make container.
    sdowell committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    f6f7401 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #910 from sdowell/e2e-image-build

    test: harden e2e image build logic
    k8s-ci-robot authored Jul 16, 2024
    Configuration menu
    Copy the full SHA
    f73ee00 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. Add docs on symlink

    thockin committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    9782ee2 View commit details
    Browse the repository at this point in the history
  2. fix: recover when there is unreleased lock file

    If a previous git invocation crashes, it is possible that an orphaned
    lock file (e.g. shallow.lock) is left on the filesystem. This previously
    caused git-sync to crash loop because the lock file is never deleted.
    
    This change adds a check in sanityCheckRepo for the existence of a git
    lock file. If the git lock file exists at this stage, then initRepo will
    re-initialize the repository.
    sdowell committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    ae22b20 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #914 from sdowell/git-lock-files

    fix: recover when there is unreleased lock file
    k8s-ci-robot authored Aug 12, 2024
    Configuration menu
    Copy the full SHA
    a5a965f View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Configuration menu
    Copy the full SHA
    69d2395 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Add support for GitHub app authentication

    Signed-off-by: Liam Wyllie <[email protected]>
    risset authored and thockin committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    0e2e0f0 View commit details
    Browse the repository at this point in the history
  2. Enable the GitHub app e2e test

    The GitHub app e2e test requires a GitHub app to be created and
    installed, and also requires a few environment variables to be set.
    
    This commit updates the GitHub action workflow by providing the
    environment variables which can be set via GitHub Secret. GitHub
    Secrests cannot start with `GITHUB_`. Hence, this commit prepends
    `TEST_` to the env variables.
    
    It also updates how GitHub app private key file is set. It can be set by
    either `TEST_GITHUB_APP_PRIVATE_KEY` or
    `TEST_GITHUB_APP_PRIVATE_KEY_FILE`.
    nan-yu authored and thockin committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    8441240 View commit details
    Browse the repository at this point in the history
  3. Fix up CI for GH app tests

    For now we skip
    thockin committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    97c0d58 View commit details
    Browse the repository at this point in the history
Loading