Skip to content

TODO: shellcheck test_e2e.sh and test_git.sh #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
thockin opened this issue Jun 13, 2024 · 5 comments · Fixed by #905
Closed

TODO: shellcheck test_e2e.sh and test_git.sh #891

thockin opened this issue Jun 13, 2024 · 5 comments · Fixed by #905
Assignees
@rul

Comments

@thockin
Copy link
Member

thockin commented Jun 13, 2024

Its kind of a mess
@rul
Copy link
Contributor

rul commented Jun 18, 2024

I'd like to give this a try. 🙂

/assign

@thockin
Copy link
Member Author

thockin commented Jun 18, 2024 via email

@rul rul mentioned this issue Jun 19, 2024
Merged
rul added a commit to rul/git-sync that referenced this issue Jun 22, 2024
@rul
test_e2e.sh: Use index to expand FUNCNAME
c8eabb1 
Fixes SC2128. Part of kubernetes#891.
@rul rul mentioned this issue Jun 22, 2024
Merged
@thockin thockin changed the title TODO: shellcheck test_e2e.sh TODO: shellcheck test_e2e.sh and test_git.sh Jun 22, 2024
@thockin
Copy link
Member Author

thockin commented Jun 22, 2024

Retitled to reference test_git.sh :)

rul added a commit to rul/git-sync that referenced this issue Jun 23, 2024
@rul
test_e2e.sh: explicitly pass parameters to 'caller' function
d67c7c6 
Fixes SC2120. Part of kubernetes#891.
rul added a commit to rul/git-sync that referenced this issue Jun 23, 2024
@rul
test_e2e.sh: remove unnecessary $ on arithmetic variables
a777cb0 
Fixes SC2004. Part of kubernetes#891.
rul added a commit to rul/git-sync that referenced this issue Jun 23, 2024
@rul
test_e2e.sh: add quotes to to prevent word splitting
144a96f 
Fixes SC2046. Part of kubernetes#891.
rul added a commit to rul/git-sync that referenced this issue Jun 23, 2024
@rul
test_e2e.sh: remove useless cats
1ab3d99 
Fixes SC2002. Part of kubernetes#891.
rul added a commit to rul/git-sync that referenced this issue Jun 23, 2024
@rul
test_e2e.sh: add '-r' to 'read' to avoid mangling backslashes
7404e05 
Fixes SC2162. Part of kubernetes#891.
rul added a commit to rul/git-sync that referenced this issue Jun 23, 2024
@rul
test_e2e.sh: Quote the rhs of != in [[ ]] to prevent glob matching
f7ccb73 
Fixes SC2053. Part of kubernetes#891.
rul added a commit to rul/git-sync that referenced this issue Jun 23, 2024
@rul
test_e2e.sh: Quote literal { }
0676ff7 
Fixes SC1083. Part of kubernetes#891.
rul added a commit to rul/git-sync that referenced this issue Jun 23, 2024
@rul
test_e2e.sh: add exceptions for SC2016
74f9f71 
Fixes SC2016. Part of kubernetes#891.
rul added a commit to rul/git-sync that referenced this issue Jun 23, 2024
@rul
test_e2e.sh: use mapfile to split command output
873b5ff 
Fixes SC2207. Part of kubernetes#891.
rul added a commit to rul/git-sync that referenced this issue Jun 23, 2024
@rul
test_e2e.sh: replace test regex for glob match
8eb31d5 
Don't quote rhs of =~, it'll match literally rather than as a
regex. Fixes SC2076. Part of kubernetes#891.
rul added a commit to rul/git-sync that referenced this issue Jun 23, 2024
@rul
test_e2e.sh: declare restore_opts and assign separately
ebfee40 
This avoids masking return values. Fixes SC2155. Part of kubernetes#891.
@rul rul mentioned this issue Jun 23, 2024
Merged
thockin pushed a commit that referenced this issue Jun 24, 2024
@rul @thockin
test_e2e.sh: explicitly pass parameters to 'caller' function
791aecf 
Fixes SC2120. Part of #891.
thockin pushed a commit that referenced this issue Jun 24, 2024
@rul @thockin
test_e2e.sh: remove unnecessary $ on arithmetic variables
e7a8600 
Fixes SC2004. Part of #891.
thockin pushed a commit that referenced this issue Jun 24, 2024
@rul @thockin
test_e2e.sh: add quotes to to prevent word splitting
bfe0a0b 
Fixes SC2046. Part of #891.
thockin pushed a commit that referenced this issue Jun 24, 2024
@rul @thockin
test_e2e.sh: remove useless cats
f41adab 
Fixes SC2002. Part of #891.
thockin pushed a commit that referenced this issue Jun 24, 2024
@rul @thockin
test_e2e.sh: add '-r' to 'read' to avoid mangling backslashes
49310e1 
Fixes SC2162. Part of #891.
thockin pushed a commit that referenced this issue Jun 24, 2024
@rul @thockin
test_e2e.sh: Quote the rhs of != in [[ ]] to prevent glob matching
1346a81 
Fixes SC2053. Part of #891.
thockin pushed a commit that referenced this issue Jun 24, 2024
@rul @thockin
test_e2e.sh: Quote literal { }
89d568d 
Fixes SC1083. Part of #891.
thockin pushed a commit that referenced this issue Jun 24, 2024
@rul @thockin
test_e2e.sh: add exceptions for SC2016
81bb72f 
Fixes SC2016. Part of #891.
thockin pushed a commit that referenced this issue Jun 24, 2024
@rul @thockin
test_e2e.sh: use mapfile to split command output
9b980c4 
Fixes SC2207. Part of #891.
thockin pushed a commit that referenced this issue Jun 24, 2024
@rul @thockin
test_e2e.sh: replace test regex for glob match
3200ee5 
Don't quote rhs of =~, it'll match literally rather than as a
regex. Fixes SC2076. Part of #891.
@thockin
Copy link
Member Author

thockin commented Jun 24, 2024

test_e2e.sh is done - now for test_git.sh ?

@rul
Copy link
Contributor

rul commented Jun 25, 2024

test_e2e.sh is done - now for test_git.sh ?

Yup! Will put up a PR soon.

rul added a commit to rul/git-sync that referenced this issue Jun 28, 2024
@rul
test_git.sh: replace test regex for glob match
99d693d 
Don't quote rhs of =~, it'll match literally rather than as a
regex. Fixes SC2076. Part of kubernetes#891.
rul added a commit to rul/git-sync that referenced this issue Jun 28, 2024
@rul
test_git.sh: quote literal {}
2ee13eb 
Fixes SC1083. Part of kubernetes#891.
rul added a commit to rul/git-sync that referenced this issue Jun 28, 2024
@rul
test_git.sh: use parameter expansion instead of sed
ae368ba 
Fixes SC2001. Part of kubernetes#891.
rul added a commit to rul/git-sync that referenced this issue Jun 28, 2024
@rul
test_git.sh: add '-r' to 'read' to avoid mangling backslashes
6716848 
Fixes SC2162. Part of kubernetes#891.
rul added a commit to rul/git-sync that referenced this issue Jun 28, 2024
@rul
test_git.sh: add quotes to to prevent globbing and word splitting
4f0dc56 
Fixes SC2086. Part of kubernetes#891.
rul added a commit to rul/git-sync that referenced this issue Jun 28, 2024
@rul
test_git.sh: use mapfile to split command output
0e81260 
Fixes SC2207. Part of kubernetes#891.
rul added a commit to rul/git-sync that referenced this issue Jun 28, 2024
@rul
test_git.sh: declare restore_opts and assign separately
d12d9f2 
This avoids masking return values. Fixes SC2155. Part of kubernetes#891.
@rul rul mentioned this issue Jun 28, 2024
Merged
rsilvestre pushed a commit to partenamut/airflow-git-sync that referenced this issue Oct 3, 2024
@rul @rsilvestre
test_e2e.sh: Use index to expand FUNCNAME
b7d24bb 
Fixes SC2128. Part of kubernetes#891.
rsilvestre pushed a commit to partenamut/airflow-git-sync that referenced this issue Oct 3, 2024
@rul @rsilvestre
test_e2e.sh: explicitly pass parameters to 'caller' function
a3cdc7b 
Fixes SC2120. Part of kubernetes#891.
rsilvestre pushed a commit to partenamut/airflow-git-sync that referenced this issue Oct 3, 2024
@rul @rsilvestre
test_e2e.sh: remove unnecessary $ on arithmetic variables
974133d 
Fixes SC2004. Part of kubernetes#891.
rsilvestre pushed a commit to partenamut/airflow-git-sync that referenced this issue Oct 3, 2024
@rul @rsilvestre
test_e2e.sh: add quotes to to prevent word splitting
4c5eb38 
Fixes SC2046. Part of kubernetes#891.
rsilvestre pushed a commit to partenamut/airflow-git-sync that referenced this issue Oct 3, 2024
@rul @rsilvestre
test_e2e.sh: remove useless cats
a40b5e0 
Fixes SC2002. Part of kubernetes#891.
rsilvestre pushed a commit to partenamut/airflow-git-sync that referenced this issue Oct 3, 2024
@rul @rsilvestre
test_e2e.sh: add '-r' to 'read' to avoid mangling backslashes
d1e4e8e 
Fixes SC2162. Part of kubernetes#891.
rsilvestre pushed a commit to partenamut/airflow-git-sync that referenced this issue Oct 3, 2024
@rul @rsilvestre
test_e2e.sh: Quote the rhs of != in [[ ]] to prevent glob matching
3b1b2cc 
Fixes SC2053. Part of kubernetes#891.
rsilvestre pushed a commit to partenamut/airflow-git-sync that referenced this issue Oct 3, 2024
@rul @rsilvestre
test_e2e.sh: Quote literal { }
604c2bc 
Fixes SC1083. Part of kubernetes#891.
rsilvestre pushed a commit to partenamut/airflow-git-sync that referenced this issue Oct 3, 2024
@rul @rsilvestre
test_e2e.sh: add exceptions for SC2016
7ed6bfe 
Fixes SC2016. Part of kubernetes#891.
rsilvestre pushed a commit to partenamut/airflow-git-sync that referenced this issue Oct 3, 2024
@rul @rsilvestre
test_e2e.sh: use mapfile to split command output
55fb6d3 
Fixes SC2207. Part of kubernetes#891.
rsilvestre pushed a commit to partenamut/airflow-git-sync that referenced this issue Oct 3, 2024
@rul @rsilvestre
test_e2e.sh: replace test regex for glob match
8f88c26 
Don't quote rhs of =~, it'll match literally rather than as a
regex. Fixes SC2076. Part of kubernetes#891.
rsilvestre pushed a commit to partenamut/airflow-git-sync that referenced this issue Oct 3, 2024
@rul @rsilvestre
test_e2e.sh: declare restore_opts and assign separately
ae126a2 
This avoids masking return values. Fixes SC2155. Part of kubernetes#891.
rsilvestre pushed a commit to partenamut/airflow-git-sync that referenced this issue Oct 3, 2024
@rul @rsilvestre
test_git.sh: replace test regex for glob match
197e75f 
Don't quote rhs of =~, it'll match literally rather than as a
regex. Fixes SC2076. Part of kubernetes#891.
rsilvestre pushed a commit to partenamut/airflow-git-sync that referenced this issue Oct 3, 2024
@rul @rsilvestre
test_git.sh: quote literal {}
1022ce6 
Fixes SC1083. Part of kubernetes#891.
rsilvestre pushed a commit to partenamut/airflow-git-sync that referenced this issue Oct 3, 2024
@rul @rsilvestre
test_git.sh: use parameter expansion instead of sed
6ce7682 
Fixes SC2001. Part of kubernetes#891.
rsilvestre pushed a commit to partenamut/airflow-git-sync that referenced this issue Oct 3, 2024
@rul @rsilvestre
test_git.sh: add '-r' to 'read' to avoid mangling backslashes
df30d7b 
Fixes SC2162. Part of kubernetes#891.
rsilvestre pushed a commit to partenamut/airflow-git-sync that referenced this issue Oct 3, 2024
@rul @rsilvestre
test_git.sh: add quotes to to prevent globbing and word splitting
de983ed 
Fixes SC2086. Part of kubernetes#891.
rsilvestre pushed a commit to partenamut/airflow-git-sync that referenced this issue Oct 3, 2024
@rul @rsilvestre
test_git.sh: use mapfile to split command output
25cdc4e 
Fixes SC2207. Part of kubernetes#891.
rsilvestre pushed a commit to partenamut/airflow-git-sync that referenced this issue Oct 3, 2024
@rul @rsilvestre
test_git.sh: declare restore_opts and assign separately
07f6392 
This avoids masking return values. Fixes SC2155. Part of kubernetes#891.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rul rul

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test_git.sh: shellcheck entire file rul/git-sync
2 participants
@rul @thockin