Skip to content

chore(go.mod): update deps to fix high cve #994 #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 10, 2025
Merged

chore(go.mod): update deps to fix high cve #994 #1035

merged 3 commits into from
Mar 10, 2025

Conversation

@daveoy
Copy link
Contributor

@daveoy daveoy commented Mar 10, 2025

should close #994

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 10, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 10, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 10, 2025

Hi @daveoy. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 10, 2025
@daveoy daveoy mentioned this pull request Mar 10, 2025
Closed
@wangzhen127
Copy link
Member

wangzhen127 commented Mar 10, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 10, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 10, 2025
@daveoy
Copy link
Contributor Author

daveoy commented Mar 10, 2025

@wangzhen127 i'll check my other PRs for this. looks like there was a change to test/go.mod somewhere along the line and this has been caught up in it.

@wangzhen127
Copy link
Member

wangzhen127 commented Mar 10, 2025

Looks like rebasing works!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: daveoy, wangzhen127

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2025
@k8s-ci-robot k8s-ci-robot merged commit e858c3d into kubernetes:master Mar 10, 2025
11 checks passed
@daveoy daveoy deleted the dy/994-2 branch March 10, 2025 22:42
aojea pushed a commit to aojea/kubernetes that referenced this pull request Jul 24, 2025
@wangzhen127
Bump NPD version to v0.8.20-71-gf6bb4f7b-gke.0
fa04e31 
https://gke-internal.googlesource.com/kubernetes/node-problem-detector/+log/f6bb4f7b5506e8bc9cb8b8e2b1c7ef009fa628c0

This NPD version contains the following 2 changes needed:
- High CVE fix: kubernetes/node-problem-detector#1035
- Custom metrics fix: kubernetes/node-problem-detector#1024

This NPD version is promoted at https://critique.corp.google.com/cl/736379160

```
$ gsutil cp "gs://gke-release-staging/node-problem-detector/node-problem-detector-v0.8.20-71-gf6bb4f7b-gke.0*tar.gz.sha512" .
$ cat *
254af832178eafa4666722b507a2556f331798c84fe9dcb9105c518d0842c13fc6f9f1fb297fe5ffa1f4656a6bfe1b6cd396175d9e2c748e3e9c6d092706bfaa  node-problem-detector-v0.8.20-71-gf6bb4f7b-gke.0-linux_amd64.tar.gz
0e2680ad176aa745c4f68f3bdf6bdd59c3d193c6605cbeb4b0192e4bc34c2d9240f6738090111d8bbfc2d7a016ee9854f02c8eaa8c7cb1543a8fe5951be0bd7a  node-problem-detector-v0.8.20-71-gf6bb4f7b-gke.0-linux_arm64.tar.gz
81e89cf9f7af0be608d9b432afb9b76ab11792d143b8529d2600bd3d9276c3b78c9548fd179f43b9626f38c115b6b0fa906f2927d72314457b4faca68b1c636e  node-problem-detector-v0.8.20-71-gf6bb4f7b-gke.0-windows_amd64.tar.gz
```

BUG: 384629347
BUG: 394504964

Change-Id: Ied5cb95672bf906c339561282899d24bf311a645
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@wangzhen127 wangzhen127

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

HIGH CVE in v0.8.20

3 participants

@daveoy @k8s-ci-robot @wangzhen127