add resource #245
add resource #245
Conversation
k8s-ci-robot
added
cncf-cla: yes
wangzhen127
left a comment
wangzhen127
left a comment
There was a problem hiding this comment.
Nit: can you fix the PR title: s/ad/add
| memory: 100Mi | ||
| requests: | ||
| cpu: 300m | ||
| memory: 100Mi |
There was a problem hiding this comment.
I tested v0.6.0 that the resource consumption is:
- CPU: 2m
- MEM: 30Mi
Maybe we should lower the numbers to something smaller, like cpu 10m and memory 50Mi to better reflect the resource consumption of NPD? WDYT?
There was a problem hiding this comment.
According to your test, it should be ok to run NPD with cpu 10m. I suggest we add more memory to avoid OOM. @wangzhen127
There was a problem hiding this comment.
Finanlly, cpu requests/limits is 10m, memory requests/limits is 80Mi.
andyxning
force-pushed
the
add_resource
branch
from
a2c5861 to
7f536cd
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
andyxning
force-pushed
the
add_resource
branch
from
7f536cd to
8c7ef9d
Compare
k8s-ci-robot
removed
the
lgtm
|
@wangzhen127 Rebased. PTAL. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyxning, wangzhen127 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
Fix #240
The requests and limits are only references. They have no requirements. End users can adjust this themselves.
/cc @Random-Liu @wangzhen127