[11.x] Allow customizing TrimStrings::$except #50901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grohiro
changed the title
milwad-dev
reviewed
Apr 3, 2024
| $except = array_merge($this->except, static::$neverTrim); | ||
|
|
||
| if (in_array($key, $except, true) || ! is_string($value)) { | ||
| if ($this->skipTrim($key, $except) || ! is_string($value)) { |
Contributor
There was a problem hiding this comment.
You've just moved in_array to a function, just this!!
Contributor
Author
There was a problem hiding this comment.
@milwad-dev
Yes, this is a hook point. You can customize the behavior like this:
class TrimArrayStrings extends TrimStrings
{
protected function skipTrim($key, $except)
{
return parent::skipTrim($key, $except) || $this->skipMoreComplexCondition($key, $except)
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that
TrimStrings::$exceptdoes not support array values likeusers.*.email.This pull request extracts new methods to allow developers to customize this behavior.
This change is fully backwards compatible.