fix(run): Exit early when no packages contain the targeted lifecycle

Author: evocateur

commands/run/__tests__/run-command.test.js

@@ -126,7 +126,9 @@ describe("RunCommand", () => {
 
       await lernaRun(testDir)("missing-script");
 
-      expect(consoleOutput()).toBe("");
+      expect(loggingOutput("success")).toContain(
+        "No packages found with the lifecycle script 'missing-script'"
+      );
     });
 
     it("runs a script in all packages with --parallel", async () => {

commands/run/index.js

@@ -47,7 +47,10 @@ class RunCommand extends Command {
     }
 
     if (!this.packagesWithScript.length) {
-      this.logger.warn(`No packages found with the npm script '${script}'`);
+      this.logger.success("run", `No packages found with the lifecycle script '${script}'`);
+
+      // still exits zero, aka "ok"
+      return false;
     }
 
     if (parallel || stream) {
@@ -70,10 +73,8 @@ class RunCommand extends Command {
     }
 
     return chain.then(() => {
-      if (this.packagesWithScript.length) {
-        this.logger.success("run", `Ran npm script '${this.script}' in packages:`);
-        this.logger.success("", this.packagesWithScript.map(pkg => `- ${pkg.name}`).join("\n"));
-      }
+      this.logger.success("run", `Ran npm script '${this.script}' in packages:`);
+      this.logger.success("", this.packagesWithScript.map(pkg => `- ${pkg.name}`).join("\n"));
     });
   }