Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: PyMySQL/Tornado-MySQL
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: levire/Tornado-MySQL
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 1 file changed
  • 1 contributor

Commits on May 12, 2015

  1. Changed the default value for max_open_connections to one. If the val…

    …ue is Leq 0 a warning over the python logging system ist emitted.
    
    Connections are now checked only against the max_open property.
    Christopher Lege committed May 12, 2015
    Configuration menu
    Copy the full SHA
    043db91 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2015

  1. Removed the default initialization for database pools. This is import…

    …ant for two reasons: First if you have a software system and you chose to use database pools you should be aware of how many connections may be opened to the database servers. Especially when using micro-services where more than one service accesses the database. Second initializing values with unlimited is useless, because there is no such thing as infinite connections to servers or the like.
    
    If the values are not initialized properly a ValueException is raised to indicate that the initialization is wrong.
    Christopher Lege committed May 14, 2015
    Configuration menu
    Copy the full SHA
    ac36f81 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2015

  1. Polished the final draft for improvements of the initialization of co…

    …nnection pools. This change is not backwards compatible. The reason for this is, that the default initialization is not useful.
    Christopher Lege committed May 18, 2015
    Configuration menu
    Copy the full SHA
    adeaa64 View commit details
    Browse the repository at this point in the history
Loading