Skip to content

fix: use failure event instead of error #3219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 13, 2025
Merged

Conversation

achingbrain
Copy link
Member

Ignore the error event as it causes raceEvent to throw. In future we should remove the error event from the queue as all we do with it is log the error, and if we want that, the failure event gives more context around the error so can make the logs more informative.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

Ignore the error event as it causes `raceEvent` to throw. In future
we should remove the error event from the queue as all we do with it
is log the error, and if we want that, the `failure` event gives
more context around the error so can make the logs more informative.
@achingbrain achingbrain requested a review from a team as a code owner July 11, 2025 16:27
@achingbrain achingbrain changed the title fix: ignore error event in test fix: use failure event instead of error Jul 13, 2025
@achingbrain achingbrain merged commit 4420fad into main Jul 13, 2025
48 of 50 checks passed
@achingbrain achingbrain deleted the fix/ignore-error-event branch July 13, 2025 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant