Return email from API

Author: lukemorton

api/swagger.yml

@@ -33,10 +33,14 @@ definitions:
   User:
     required:
       - name
+      - email
     properties:
       name:
         type: string
         example: "Mr Bob Example"
+      email:
+        type: string
+        example: "[email protected]"
   Error:
     required:
       - message

lib/user/FakeUserGateway.ts

@@ -1,5 +1,5 @@
 import User from './User'
 
 export async function findById (id: string) : Promise<User> {
-  return new User('Luke (fake!)', 'luke@cool.com')
+  return new User('Mr Luke Fake', 'luke@example.com')
 }

lib/user/HTTPUserGateway.test.ts

@@ -6,9 +6,10 @@ const API_ORIGIN = process.env.API_ORIGIN
 describe('HTTPUserGateway', () => {
   describe('when finding by id', () => {
     test('user has name', async () => {
-      nock(API_ORIGIN).get('/api/users/guid').reply(200, { name: 'Jim' })
+      nock(API_ORIGIN).get('/api/users/guid').reply(200, { name: 'Jim', email: '[email protected]' })
       const user = await HTTPUserGateway.findById('guid')
       expect(user.name).toBe('Jim')
+      expect(user.email).toBe('[email protected]')
     })
   })
 })

lib/user/HTTPUserGateway.ts

@@ -5,6 +5,6 @@ const API_ORIGIN = process.env.API_ORIGIN
 
 export async function findById (id: string) : Promise<User> {
   const res = await fetch(`${API_ORIGIN}/api/users/${id}`)
-  const { name } = await res.json()
-  return new User(name, '[email protected]')
+  const { name, email } = await res.json()
+  return new User(name, email)
 }

lib/user/LoadUserProfile.test.ts

@@ -5,7 +5,7 @@ describe('LoadUserProfile', () => {
   describe('when loading profile by id', () => {
     test('user has name', async () => {
       const { user } = await LoadUserProfile(FakeUserGateway, { id: 'guid' })
-      expect(user.name).toBe('Luke (fake!)')
+      expect(user.name).toBe('Mr Luke Fake')
     })
   })
 })