Skip to content

[Issue] Removed code redundancy for module frontend layouts. #30673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
4 tasks
m2-assistant bot opened this issue Oct 27, 2020 · 4 comments · May be fixed by #30644
Open
4 tasks

[Issue] Removed code redundancy for module frontend layouts. #30673

m2-assistant bot opened this issue Oct 27, 2020 · 4 comments · May be fixed by #30644
Labels
Area: Framework Component: LoginAsCustomerAssistance Component: Msrp Component: Newsletter Component: Sitemap Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Oct 27, 2020

This issue is automatically created based on existing pull request: #30644: Removed code redundancy for module frontend layouts.

Description (*)

Removed code redundancy to theme layouts for Magento_Msrp, Magento_LoginAsCustomerAssistance, Magento_Newsletter & Magento_Sitemap modules frontend layouts.

Related Pull Requests

N/A

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

N/A

Questions or comments

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: LoginAsCustomerAssistance Component: Msrp Component: Newsletter Component: Sitemap Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Oct 27, 2020
@m2-assistant m2-assistant bot linked a pull request Oct 27, 2020 that will close this issue
Open
5 tasks
@sdzhepa sdzhepa added the Reported on 2.4.x Indicates original Magento version for the Issue report. label Nov 11, 2020
@magento-engcom-team magento-engcom-team added Reported on 2.4.0 Indicates original Magento version for the Issue report. and removed Reported on 2.4.x Indicates original Magento version for the Issue report. labels Nov 16, 2020
@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Mar 30, 2021
@engcom-Oscar engcom-Oscar added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Mar 31, 2021
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Oscar
Thank you for verifying the issue. Based on the provided information internal tickets MC-41676 were created

Issue Available: @engcom-Oscar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@ihor-sviziev ihor-sviziev removed the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Mar 31, 2021
@m2-community-project m2-community-project bot added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Apr 2, 2021
@ihor-sviziev ihor-sviziev removed the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Apr 2, 2021
@engcom-Hotel engcom-Hotel moved this to Pull Request In Progress in High Priority Backlog Aug 19, 2024
@engcom-Dash
Copy link
Contributor

Hello @pratiksangani
Thanks for the report and collaboration!

We have looked into the attached PR of this issue and found that the PR is related to removing the redundant code from the frontend page layouts.

Hence re-confirming this issue.

@engcom-Dash engcom-Dash added Area: Framework Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels May 9, 2025
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-14625 is successfully created for this GitHub issue.

@m2-assistant M2 Assistant
Copy link
Author

m2-assistant bot commented May 9, 2025

✅ Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Framework Component: LoginAsCustomerAssistance Component: Msrp Component: Newsletter Component: Sitemap Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
High Priority Backlog
Status: Pull Request In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed code redundancy for module frontend layouts. pratiksangani/magento2
6 participants
@ihor-sviziev @sdzhepa @magento-engcom-team @engcom-Oscar @engcom-Dash @github-jira-sync-bot