Skip to content

Fix Magento logging #32387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task
adamlavery opened this issue Mar 5, 2021 · 11 comments
Closed
1 task

Fix Magento logging #32387

adamlavery opened this issue Mar 5, 2021 · 11 comments
Labels
Area: Other Developer Tools Component: Reports Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: ready for dev Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@adamlavery
Copy link

adamlavery commented Mar 5, 2021

Preconditions (*)

  1. Install any version of Magento 2

Steps to reproduce (*)

  1. Set mode to Developer
  2. Enable Debug

Expected result (*)

  1. Debug log will contain debug logs only
  2. Cron log will contain cron logs only
  3. System log will contain system logs only

Actual result (*)

  1. Debug log contains everything that is also logged to cron,log and system.log
  2. System log contains everything that is also logged to cron.log
  3. Cron log only contains cron logs - got that one right!

  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

Please address the mishandling of logs so that logs contain just what is necessary and desired.

  • Debug log should contain just logs identified as "debug"
  • System log should not duplicate everything written to cron.log

As a further request, please address the issue of "broken references" that fill the system (and debug logs!). There should be a switch to disable these logs. In the main they are not useful and cannot/will not be addressed. "Broken references" are always going to happen when using extensions/themes from multiple sources. Very few will be interested in these - the majority of us are not so these are pointless and just make reviewing logs more difficult.

@m2-assistant
Copy link

m2-assistant bot commented Mar 5, 2021

Hi @adamlavery. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@stale
Copy link

stale bot commented May 20, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

@stale stale bot added the stale issue label May 20, 2021
@dverkade
Copy link
Member

Issues waiting for confirmation should not be closed automatically.

@stale stale bot closed this as completed Jun 4, 2021
@rosemariepopescu
Copy link

Waiting for an answer here as well! Issue is pretty straight forward, clearly explained and it bothers us all developers!!

@fredden
Copy link
Member

fredden commented Aug 22, 2022

@sidolov please can you re-open this so it can be triaged. It looks like it was closed by the stale robot by mistake.

@m2-assistant
Copy link

m2-assistant bot commented Sep 28, 2022

Hi @engcom-Lima. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

Page not found · GitHub · GitHub
Skip to content
404 “This is not the web page you are looking for”
@engcom-Lima engcom-Lima added Reported on 2.4.x Indicates original Magento version for the Issue report. Reported on 2.4.0 Indicates original Magento version for the Issue report. and removed Reported on 2.4.0 Indicates original Magento version for the Issue report. labels Sep 28, 2022
@engcom-Lima
Copy link
Contributor

✔️ Issue confirmed

Issue got reproduced in 2.4-develop branch.

Description: Magento logs are not coming properly.

Pre-requisite:

  • Fresh magento 2.4-develop should be installed.

Steps to reproduce:

  1. Set mode to Developer
  2. Enable Debug
  3. Check logs in var/log/

Expected result:

  1. Debug log will contain debug logs only
  2. Cron log will contain cron logs only
  3. System log will contain system logs only

Actual result:

  1. Debug log contains everything that is also logged to cron,log and system.log
  2. System log contains everything that is also logged to cron.log
  3. Cron log only contains cron logs.

Screenshots:
Debug logs:
image

System log :
image

@engcom-Lima engcom-Lima added Area: Other Developer Tools Component: Reports Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch and removed stale issue labels Sep 29, 2022
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-6767 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Sep 29, 2022

✅ Confirmed by @engcom-Lima. Thank you for verifying the issue.
Issue Available: @engcom-Lima, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@sdzhepa sdzhepa added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Sep 29, 2022
@engcom-Hotel engcom-Hotel moved this to Ready for Development in Low Priority Backlog Aug 19, 2024
@engcom-Bravo
Copy link
Contributor

Hi @adamlavery,

Thanks for your reporting and collaboration.

We have tried to reproduce the issue in Latest 2.4-develop instance and we are not able to reproduce the issue.Kindly refer the screenshots.

Image
  1. Debug log will contain debug logs only
  2. Cron log will contain cron logs only
  3. System log will contain system logs only

Hence we are closing this issue.

Thanks.

@adamlavery
Copy link
Author

Ok, great. What release is this fix going in or has gone in? We can't see Jira tickets. Shouldn't there be a "Fixed in X.Y.Z" label?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Other Developer Tools Component: Reports Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: ready for dev Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Development

No branches or pull requests

9 participants