Skip to content

Provide a feature to mass-delete tax rates using the grid #33399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hostep opened this issue Jul 1, 2021 · 10 comments
Closed

Provide a feature to mass-delete tax rates using the grid #33399

hostep opened this issue Jul 1, 2021 · 10 comments
Assignees
Labels
Area: Admin UI feature request Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Priority: P3 May be fixed according to the position in the backlog. Progress: done Progress: PR Created Indicates that Pull Request has been created to fix issue Progress: PR in progress Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@hostep
Copy link
Contributor

hostep commented Jul 1, 2021

Description (*)

It would be great if the tax rates grid had an option to mass-delete rates.

Expected behavior (*)

So the same feature as the cms pages grid has for example: an option to select multiple rows of tax rates and having an action to delete them all together.

Benefits

Saving tons of time.

Today I implemented the new EU tax system that started as of today, and I imported a whole bunch of new rates, but I also had to cleanup the old rates, and currently this needed to be done one by one, which took me several hours. I think I've manually deleted ~600 rates today by hand over ~20 different shops. Which was no fun at all.

Additional information

Thanks!

@m2-assistant
Copy link

m2-assistant bot commented Jul 1, 2021

Hi @hostep. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-assistant
Copy link

m2-assistant bot commented Jul 1, 2021

Hi @krishprakash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

Page not found · GitHub · GitHub
Skip to content
404 “This is not the web page you are looking for”
@krishprakash krishprakash added Component: Tax Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Progress: ready for grooming Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch and removed Progress: dev in progress labels Jul 1, 2021
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @krishprakash
Thank you for verifying the issue. Based on the provided information internal tickets MC-42774 were created

Issue Available: @krishprakash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@vlmed
Copy link
Contributor

vlmed commented Jul 7, 2021

@magento I am working on this

@m2-community-project m2-community-project bot added the Priority: P3 May be fixed according to the position in the backlog. label Aug 5, 2021
@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels Oct 25, 2021
@engcom-Hotel engcom-Hotel added Area: Admin UI Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: Admin UI labels Jan 21, 2022
@engcom-Hotel engcom-Hotel added Area: Admin UI Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: Admin UI labels Feb 1, 2022
@github-jira-sync-bot
Copy link

github-jira-sync-bot commented Feb 1, 2022

✅ Jira issue https://jira.corp.adobe.com/browse/AC-2238 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Feb 1, 2022

✅ Confirmed by @engcom-Hotel. Thank you for verifying the issue.
Issue Available: @engcom-Hotel, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@m2-community-project m2-community-project bot added the Priority: P3 May be fixed according to the position in the backlog. label Feb 3, 2022
@github-jira-sync-bot github-jira-sync-bot added the Progress: PR Created Indicates that Pull Request has been created to fix issue label Aug 21, 2023
@engcom-Hotel engcom-Hotel moved this to Pull Request in Progress in Feature Requests Backlog Aug 19, 2024
@github-jira-sync-bot github-jira-sync-bot changed the title Provide a feature to mass-delete tax rates using the grid FPT value in cart page and product page are different for same configurations Sep 23, 2024
@engcom-Bravo
Copy link
Contributor

Hi @hostep,

Adobe Commerce Engineering team started working on this issue. We will reach out to you if we need more information and you will get notified once the issue is fixed. Please leave comments for any further questions.

Thank you!

@hostep hostep changed the title FPT value in cart page and product page are different for same configurations Introduce a feature to mass-delete tax rates Apr 21, 2025
@hostep
Copy link
Contributor Author

hostep commented Apr 21, 2025

Closing as this got implemented in ce0a2bd

@hostep hostep closed this as completed Apr 21, 2025
@hostep hostep changed the title Introduce a feature to mass-delete tax rates Provide a feature to mass-delete tax rates using the grid Apr 21, 2025
@engcom-Bravo
Copy link
Contributor

Hi @hostep,

Thank you for your valuable contribution. The Adobe Commerce Engineering team has reviewed the contributor's PR and found that the implementation was outdated, requiring additional classes and the inclusion of an extra "getColumnValues" method. As a result, Adobe Commerce Engineering team has decided not to proceed with the external PR and instead worked on a new implementation to fixed the issue.

Commit link : https://github.com/search?q=repo%3Amagento%2Fmagento2+AC-2238&type=commits

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Admin UI feature request Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Priority: P3 May be fixed according to the position in the backlog. Progress: done Progress: PR Created Indicates that Pull Request has been created to fix issue Progress: PR in progress Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Status: Pull Request in Progress
Development

Successfully merging a pull request may close this issue.

8 participants