Email module breaks setup:upgrade in 2.4.3-p2

[enr-beck-mellow]

Preconditions (*)

1. Magento 2.4.3-p2
2. PHP 7.3

Steps to reproduce (*)

1. Setup new environment with magento 2.4.3-p2 and php 7.3
   Running composer create-project command does not give any error but running php bin/magento setup:install command returns an error which is not meaningful / clear

Expected result (*)

composer create-project command returns below meaningful error:
#35342 (comment)

Actual result (*)

1. A syntax error occurs when Composer ClassLoader includes "Magento\Email\Console\Command\DatabaseTemplateCompatibilityCommand" because php 7.4 functionality is used (typed properties: https://www.php.net/manual/en/migration74.new-features.php#migration74.new-features.core.typed-properties)
2. syntax error, unexpected 'CollectionFactory' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)#0 /var/www/html/vendor/composer/ClassLoader.php(322): Composer\Autoload\includeFile('/var/www/html/v...') #1 [internal function]: Composer\Autoload\ClassLoader->loadClass('Magento\\Email\\C...') #2 [internal function]: spl_autoload_call('Magento\\Email\\C...') #3 /var/www/html/vendor/magento/framework/ObjectManager/Relations/Runtime.php(38): class_exists('Magento\\Email\\C...') #4 /var/www/html/vendor/magento/framework/Interception/Config/Config.php(157): Magento\Framework\ObjectManager\Relations\Runtime->has('Magento\\Email\\C...') #5 /var/www/html/vendor/magento/framework/Interception/Config/Config.php(180): Magento\Framework\Interception\Config\Config->_inheritInterception('Magento\\Email\\C...') #6 /var/www/html/vendor/magento/framework/Interception/ObjectManager/Config/Developer.php(61): Magento\Framework\Interception\Config\Config->hasPlugins('Magento\\Email\\C...') #7 /var/www/html/vendor/magento/framework/ObjectManager/Factory/Dynamic/Developer.php(47): Magento\Framework\Interception\ObjectManager\Config\Developer->getInstanceType('Magento\\Email\\C...') #8 /var/www/html/vendor/magento/framework/ObjectManager/ObjectManager.php(70): Magento\Framework\ObjectManager\Factory\Dynamic\Developer->create('Magento\\Email\\C...') #9 /var/www/html/vendor/magento/framework/ObjectManager/Factory/AbstractFactory.php(206): Magento\Framework\ObjectManager\ObjectManager->get('Magento\\Email\\C...') #10 /var/www/html/vendor/magento/framework/ObjectManager/Factory/AbstractFactory.php(182): Magento\Framework\ObjectManager\Factory\AbstractFactory->parseArray(Array) #11 /var/www/html/vendor/magento/framework/ObjectManager/Factory/AbstractFactory.php(276): Magento\Framework\ObjectManager\Factory\AbstractFactory->resolveArgument(Array, NULL, Array, 'commands', 'Magento\\Framewo...') #12 /var/www/html/vendor/magento/framework/ObjectManager/Factory/AbstractFactory.php(239): Magento\Framework\ObjectManager\Factory\AbstractFactory->getResolvedArgument('Magento\\Framewo...', Array, Array) #13 /var/www/html/vendor/magento/framework/ObjectManager/Factory/Dynamic/Developer.php(34): Magento\Framework\ObjectManager\Factory\AbstractFactory->resolveArgumentsInRuntime('Magento\\Framewo...', Array, Array) #14 /var/www/html/vendor/magento/framework/ObjectManager/Factory/Dynamic/Developer.php(59): Magento\Framework\ObjectManager\Factory\Dynamic\Developer->_resolveArguments('Magento\\Framewo...', Array, Array) #15 /var/www/html/vendor/magento/framework/ObjectManager/ObjectManager.php(56): Magento\Framework\ObjectManager\Factory\Dynamic\Developer->create('Magento\\Framewo...', Array) #16 /var/www/html/vendor/magento/framework/Console/Cli.php(153): Magento\Framework\ObjectManager\ObjectManager->create('Magento\\Framewo...') #17 /var/www/html/vendor/magento/framework/Console/Cli.php(134): Magento\Framework\Console\Cli->getApplicationCommands() #18 /var/www/html/vendor/symfony/console/Application.php(1274): Magento\Framework\Console\Cli->getDefaultCommands() #19 /var/www/html/vendor/symfony/console/Application.php(629): Symfony\Component\Console\Application->init() #20 /var/www/html/vendor/symfony/console/Application.php(237): Symfony\Component\Console\Application->find('s:up') #21 /var/www/html/vendor/magento/framework/Console/Cli.php(115): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) #22 /var/www/html/vendor/symfony/console/Application.php(149): Magento\Framework\Console\Cli->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) #23 /var/www/html/bin/magento(23): Symfony\Component\Console\Application->run() #24 {main}

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @enr-beck-mellow. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[hostep]

Even though technically Magento 2.4.3-p2 is installable with PHP 7.3 using composer (not sure why they still allow this?), it's not recommended and the system requirements specify that it was only tested with PHP 7.4.

So I'm not sure if they will consider this as a valid bug report. You'd probably best want to upgrade to PHP 7.4 in order to solve this.

What would be a valid bug report, is that Magento 2.4.3-p2 is still installable with composer using PHP 7.3, in my opinion this should no longer be allowed when they explicitly switch to PHP 7.4 syntax here and there.

[enr-beck-mellow]

Good point. I didnt lookup the system requirements because composer installed it without any problems.

[m2-assistant]

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[CronoxAU]

Just want to add a comment that I encountered the same issue testing 2.4.3-p2 on PHP 7.3.

This thread was invaluable in finding the issue, and thanks @hostep for the system requirements chart which does make the issue clear.

Given that previously 2.4.3 ran without any issues on PHP 7.3 I think adding some clear notification that PHP 7.4 is now required would be very beneficial.

[engcom-November]

Hi @enr-beck-mellow ,
Thank you for reporting and collaboration. Verified this issue by installing Magento 2.4.3-p2 with php 7.3 and running composer create-project command does not give any error but running php bin/magento setup:install command returns an error which is not meaningful / clear

Expected behavior:
composer create-project command returns below meaningful error:

Hence confirming this issue.

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.magento.com/browse/AC-2910 is successfully created for this GitHub issue.

[m2-assistant]

✅ Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[engcom-Bravo]

Hi @enr-beck-mellow,

Thanks for your reporting and collaboration.

We are closing this issue.

Thanks.