Skip to content

.ui-state-focus missing from main navigation in 2.4.5 and 2.4.6 #37300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 of 5 tasks
schizek opened this issue Mar 27, 2023 · 20 comments
Open
1 of 5 tasks

.ui-state-focus missing from main navigation in 2.4.5 and 2.4.6 #37300

schizek opened this issue Mar 27, 2023 · 20 comments
Labels
Area: Frontend Component: Frontend Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reported on 2.4.5 Indicates original Magento version for the Issue report. Reported on 2.4.6 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@schizek
Copy link

schizek commented Mar 27, 2023

Preconditions and environment

  • Magento version: 2.4.5 and 2.4.6

Steps to reproduce

  1. Install a vanilla Magento version 2.4.5 - 2.4.6
  2. Open developer tools and inspect a submenu item in the main navigation to watch classes
  3. Using keyboard tab to the main menu then use arrow keys to navigate to submenu items

Expected result

When focus is on a menu item a class should be added of ui-state-focus

Actual result

No ui-state-focus class is added, just ui-state-active

Additional information

Accessibility issue introduced in 2.4.5 and remains an issue in 2.4.6. The ui-state-focus class is missing on items in the menu in focus preventing styles from being added visually identifying which element is in focus for keyboard only users. This violates WCAG Success Criteria 2.4.7 Focus Visible (Level AA). The class exists as expected in version 2.4.3-p2.

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Mar 27, 2023

Hi @schizek. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@m2-assistant
Copy link

m2-assistant bot commented Mar 27, 2023

Hi @engcom-Dash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

    1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
    1. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
    1. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

@engcom-Dash engcom-Dash added Reported on 2.4.5 Indicates original Magento version for the Issue report. Reported on 2.4.6 Indicates original Magento version for the Issue report. labels Mar 28, 2023
@engcom-Dash
Copy link
Contributor

@magento give me 2.4.6 instance

@magento-deployment-service
Copy link

Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@engcom-Dash
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@engcom-Dash
Copy link
Contributor

@magento give me 2.4.3-p3 instance

@magento-deployment-service
Copy link

Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

Hi @engcom-Dash, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@engcom-Dash
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@engcom-Dash
Copy link
Contributor

Hi @schizek ,

Verified the issue in 2.4-develop instance and 2.4.6 and the issue is reproducible,Hence we are confirming the issue.Kindly refer the screenshots.

Preconditions:

Magento version 2.4-develop instance and 2.4.6 instance
PHP version 8.1

Steps to reproduce:
1.Install 2.4-develop instance and 2.4.6 Magento instance
2.Open developer tools and inspect a submenu in front end.
3.If You are navigating arrow key to sub menu items ui-state-active is present

Kindly refer the screenshots:
Screenshot 2023-05-02 at 8 44 04 AM
Screenshot 2023-05-02 at 8 44 24 AM

Ui-state-active is present instead of ui-state-focus ,this is actual result in both 2.4-develop instance and 2.4.6
Issue can be reproducible,Hence we are cinfirming the issue.

Regards,

@engcom-Dash engcom-Dash added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Component: Frontend Area: Admin UI labels May 3, 2023
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-8667 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented May 3, 2023

✅ Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-Bravo engcom-Bravo added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label May 4, 2023
@rostilos
Copy link
Contributor

@magento I am working on this

@engcom-Delta
Copy link
Contributor

Hi @schizek ,

Thanks for your reporting and collaboration.
We have re-verified the issue in latest 2.4-develop instance hence reconfirming the issue.
Kindly refer the screenshots.

Steps to reproduce :

Install a vanilla Magento 2.4 develop instance
Open developer tools and inspect a submenu item in the main navigation to watch classes
Using keyboard tab to the main menu then use arrow keys to navigate to submenu items
Expected result
When focus is on a menu item a class should be added of ui-state-focus

Actual result
No ui-state-focus class is added, just ui-state-active

Image

Thanks.

@engcom-Delta engcom-Delta added Area: Frontend Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Component: Frontend and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Component: Frontend Area: Admin UI labels Apr 15, 2025
@github-jira-sync-bot
Copy link

❌ Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.adobe.com/browse/AC-8667

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Component: Frontend Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reported on 2.4.5 Indicates original Magento version for the Issue report. Reported on 2.4.6 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants