Skip to content

CMS Page InlineEdit not working sometimes when select to last column #37506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
5 tasks
yihang861 opened this issue May 16, 2023 · 15 comments
Open
5 tasks

CMS Page InlineEdit not working sometimes when select to last column #37506

yihang861 opened this issue May 16, 2023 · 15 comments
Labels
Area: Admin UI Component: Cms Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: ready for dev Reported on 2.4.5-p1 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@yihang861
Copy link

yihang861 commented May 16, 2023

Preconditions and environment

  • Magento version Magento ver. 2.4.5-p1
  • Anything else that would help a developer reproduce the bug

Steps to reproduce

1 go admin Cms Page
2 Clicking on a line trigger the edit editor.
3 then click checkbox one by one to last column
4 the last column will not trigger editor sometimes.
微信截图_20230516183321

this issue can reproduce in cms block as well

image

Expected result

All column can show editor normal.

Actual result

The last column can not show editor sometimes

Additional information

No response

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented May 16, 2023

Hi @yihang861. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@m2-assistant
Copy link

m2-assistant bot commented May 16, 2023

Hi @engcom-Dash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

    1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
    1. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
    1. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

@engcom-Dash engcom-Dash added the Reported on 2.4.5-p1 Indicates original Magento version for the Issue report. label May 16, 2023
@engcom-Dash
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@engcom-Dash
Copy link
Contributor

Hi @

Verified the issue in 2.4-develop instance and the issue is not reproducible.

Steps to reproduce:

  • install magento instance
  • Go to admin >CMS page>Click In line editor
  • Edit the column and save

Kindly refer the below screenshots:
Screenshot 2023-05-16 at 5 56 58 PM

Screenshot 2023-05-16 at 7 19 20 PM

We can edit the CMS Page or Block in 2.4-develop instance, Kindly provide more information if the issue still reproducible.

@engcom-Dash engcom-Dash added the Issue: needs update Additional information is require, waiting for response label May 16, 2023
@yihang861
Copy link
Author

Hi @engcom-Dash, edit one column is working fine , but if have many coloums and select one by one , the last one column will not show editors sometimes.
image

@yihang861
Copy link
Author

Please follow the steps .
image
image
image
image

@yihang861
Copy link
Author

It's not a problem that happens all the time, it happens sometimes, so it's hard for me to identify what is it。
Just know is the problem with
/var/www/magento_demo/vendor/magento/module-ui/view/base/web/js/lib/knockout/bindings/staticChecked.js.
and
in updateModel function.
ko.utils.addOrRemoveItem(modelValue, elemValue, isChecked);

@engcom-Dash
Copy link
Contributor

Hi @yihang861 ,

Thanks for the updates,

Verified the issue in 2.4-develop instance and the issue is reproducible.

Preconditions:
Magento version 2.4-develop and PHP 8.1

Kindly refer the below screenshots:
Screenshot 2023-05-17 at 5 15 42 PM
Screenshot 2023-05-17 at 5 16 22 PM

If we selecting the columns one by one, the last column is not showing with editors.

Thanks.

@engcom-Dash engcom-Dash added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: Admin UI and removed Issue: needs update Additional information is require, waiting for response labels May 17, 2023
@m2-community-project m2-community-project bot added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels May 17, 2023
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-8792 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented May 17, 2023

✅ Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@github-jira-sync-bot
Copy link

❌ You don't have permission to export this issue.

@engcom-Bravo engcom-Bravo added the Priority: P3 May be fixed according to the position in the backlog. label May 17, 2023
@engcom-Hotel engcom-Hotel moved this to Ready for Development in Low Priority Backlog Aug 19, 2024
@engcom-Delta
Copy link
Contributor

Hi @yihang861 ,

Thanks for your reporting and collaboration.
We have re-verified the issue in latest 2.4-develop instance hence reconfirming the issue.
Kindly refer the screenshots.

Steps to reproduce :
1 go admin Cms Page
2 Clicking on a line trigger the edit editor.
3 then click checkbox one by one to last column
4 the last column will not trigger editor sometimes.

Image

Thanks.

@engcom-Delta engcom-Delta added Component: Cms Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: Admin UI and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: Admin UI labels Apr 16, 2025
@github-jira-sync-bot
Copy link

❌ Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.adobe.com/browse/AC-8792

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Admin UI Component: Cms Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: ready for dev Reported on 2.4.5-p1 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Development

No branches or pull requests

5 participants