Skip to content

Category issue : load disable category at page builder's component category drop-down #37646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
5 tasks
alpesh2689 opened this issue Jun 21, 2023 · 19 comments · May be fixed by #37649
Open
5 tasks

Category issue : load disable category at page builder's component category drop-down #37646

alpesh2689 opened this issue Jun 21, 2023 · 19 comments · May be fixed by #37649
Assignees
Labels
Area: Content Component: PageBuilder Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reported on 2.4.6 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@alpesh2689
Copy link

Preconditions and environment

  • Magento version - 2.4.5, 2.4.6
  • Page Builder

Steps to reproduce

  • Go to Content -> Pages -> edit page

  • Open Content and edit content with page builder

  • Select Slider OR Product component from the left bar menu

  • edit that component
    image

  • open category dropwon
    image

In the above snap that disable category also loaded.

Expected result

If Admin disabled any category from Catalog -> Categories then it should not be visible OR listed in the page builder's any component related to category dropdown.

Actual result

If Admin disabled any category from Catalog -> Categories then it is visible OR listed at the page builder's component related to the category dropdown

Additional information

Suppose we need to load the top category list at the home page using the page builder at that time any category disable
( If Admin disabled any category from Catalog -> Categories then it is visible OR listed at the page builder's component related to the category dropdown )

So that category link redirects to 404

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Jun 21, 2023

Hi @alpesh2689. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@m2-assistant
Copy link

m2-assistant bot commented Jun 21, 2023

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.6 Indicates original Magento version for the Issue report. label Jun 21, 2023
@alpesh2689
Copy link
Author

@magento I am working on this

@m2-assistant
Copy link

m2-assistant bot commented Jun 21, 2023

Hi @alpesh2689! 👋
Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

@alpesh2689
Copy link
Author

@magento add to contributors team

@m2-assistant
Copy link

m2-assistant bot commented Jun 21, 2023

Hi @alpesh2689! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and add your comment one more time.

@alpesh2689
Copy link
Author

@magento I am working on this

@engcom-Bravo
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@alpesh2689 alpesh2689 linked a pull request Jun 21, 2023 that will close this issue
5 tasks
@engcom-Bravo
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@engcom-Bravo
Copy link
Contributor

Hi @alpesh2689,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance and the issue is reproducible.Kindly refer the attached screenshots.

Steps to reproduce

  • Go to Content -> Pages -> edit page
  • Open Content and edit content with page builder
  • Select Slider OR Product component from the left bar menu
  • edit that component

We have disabled category JACKETS from Mens>Tops.In frontend it is not showing and it is working fine.

Screenshot 2023-06-22 at 12 17 33 PM

While editing the content using pagebuilder category JACKETS is still showing in the category tree even it is disabled.

Screenshot 2023-06-22 at 12 21 10 PM

Hence Confirming the issue.

Thanks.

@engcom-Bravo engcom-Bravo added Area: Catalog Component: PageBuilder Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Jun 22, 2023
@engcom-Bravo engcom-Bravo added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Issue: ready for confirmation labels Jun 22, 2023
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-9052 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Jun 22, 2023

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@craigfleming
Copy link

Many merchants who use Page Builder product carousel or grid content type would argue that this is not an issue, but a desirable feature. Allowing users to choose disabled categories within Page Builder provides a simple way to collate best-selling or high-stock products to show on the front end of any Magento website without having to choose from a long list of product SKU's. It helps to streamline a workflow for merchandising products on any Magento system.

@engcom-Bravo - This is a step backwards for Magento Page Builder. My vote would be to close this issue as it's not an issue at all but a way for @alpesh2689 to make an easy pull request into an Open Source project for his CV.

@alpesh2689
Copy link
Author

@craigfleming Thank you for your comment on the reported issue regarding the Magento 2 Page Builder. However, I would like to clarify some details to ensure a better understanding of the situation.

I want to clarify that the intention behind reporting this issue is to improve the functionality and user experience of the Page Builder, not for personal gain or to enhance my CV. The issue has been reported based on real experiences faced while working with the feature. As per the below Image, it allows to add link of disabled categories too which leads to a 404 page when the content is created. This behavior is causing inconvenience and potential usability issues for users.

image

While your comment suggests that this might be intended functionality or a feature rather than an issue, I would like to emphasize that the ability to select a disabled category in the Page Builder is resulting in broken links and poor user experience. It is important to ensure that the Page Builder only allows the selection of active and valid categories to prevent such issues.

If you have any further insights or information regarding this matter, I would appreciate your input. However, if you believe that this behavior is indeed intended and not an issue, kindly provide more context or guidelines to help us understand the reasoning behind it.

Thank you for your attention to this matter, and I look forward to further discussions and resolution.

@engcom-Bravo Thanks for confirming the issue after seeing it in detail.

@engcom-Delta
Copy link
Contributor

Hi @alpesh2689 ,

Thanks for your reporting and collaboration.
We have re-verified the issue in latest 2.4-develop instance hence reconfirming the issue.
Kindly refer the screenshots

Steps to reproduce :
o to Content -> Pages -> edit page
Open Content and edit content with page builder
Select Slider OR Product component from the left bar menu
edit that component
We have disabled category Women .In frontend it is not showing and it is working fine.
While editing the content using pagebuilder category Women is still showing in the category tree even it is disabled.

Image

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Content Component: PageBuilder Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reported on 2.4.6 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants