-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Complete cache invalidation on Magento 2.4.6 #37834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @ahmed-midori. Thank you for your report.
Join Magento Community Engineering Slack and ask your questions in #github channel. |
Hi @engcom-Dash. Thank you for working on this issue.
|
@magento give me 2.4-develop instance |
Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you. |
Hi @engcom-Dash, here is your Magento Instance: https://daea483f5e87b5e18cabdeb4db3f15c6.instances-prod.magento-community.engineering |
Thank you Rajasekar Panneerselvam for confirming the issue.
Im sure you will agree that it is not correct that cache for every single product and pages gets invalidated because one product switches to out of stock. Likewise it is not correct that every product and page gets invalidated if a single product is edited in admin.
This is quite frustrating if you have a site with say 30,000 active products and a single product goes out of stock invalidating all 30,000 products.
From: Rajasekar Panneerselvam ***@***.***>
Sent: Thursday, August 3, 2023 11:58 AM
To: magento/magento2 ***@***.***>
Subject: Re: [magento/magento2] Complete cache invalidation on Magento 2.4.6 (Issue #37834)
Hi @ahmed-midori<https://github.com/ahmed-midori> ,
Verified the issue in 2.4-develop instance and the issue is reproducible,Hence we are confirming the issue.
If we shipment is created for the last available qty of a product making the product out of stock the complete site cache is invalidated and any change is made to a product in admin such as change to product title or description then this also completely invalidates all cache site wide.
Kindly refer the below screenshots:
[Screenshot 2023-08-03 at 3 16 45 PM]<https://user-images.githubusercontent.com/60198592/258075260-e9b20d4b-ba15-42e0-a367-1642eecf6c15.png>
[Screenshot 2023-08-03 at 3 18 11 PM]<https://user-images.githubusercontent.com/60198592/258075320-27c6efc5-f1d9-4368-8923-baa4291c8482.png>
[Screenshot 2023-08-03 at 3 20 22 PM]<https://user-images.githubusercontent.com/60198592/258075337-65e2c16e-0f6f-4e92-9d1d-cedeef83295e.png>
[Screenshot 2023-08-03 at 3 21 14 PM]<https://user-images.githubusercontent.com/60198592/258075349-6df0b03b-9079-4fae-9dcb-1e3e37a66124.png>
[Screenshot 2023-08-03 at 3 21 29 PM]<https://user-images.githubusercontent.com/60198592/258075355-2559545a-186f-49b7-9025-58155f4e9104.png>
—
|
Hi @ahmed-midori , Sorry for inconvenience, As discussed with internal team,We verified the issue in 2.4-develop instance and its not reproducible. |
Hi @engcom-Dash, Thank you for your response. Please find below screenshots confirming the issue. You will see screenshots from the homepage, 2 different category pages, 2 different product pages and also a CMS page. All clearly show a cache hit. As you will see from all the above screenshots all are showing a hit. I then go to a product as per screenshots below and zero the qty's making the product out of stock: Following the change of qty to zero/out of stock you will see that cache for everything becomes invalid as per screenshots below: I can confirm that this cache invalidation occurs with every single product on the website, every single category, the homepage and all cms pages. All by just one product going out of stock. Further to this and in relation to changes made to a product in admin I can confirm that a change to a product title for example performs exactly the same invalidation to all products, categories, cms pages and homepage. Surely it cant be normal that in the instance where you have 100,000 products all cached and one of those products go out of stock all the other 99,999 products return a cache miss. Equally if a product is edited. Please can you check. You will find that if you set a product qty to zero or change some such as title every single product, category, homepage, CMS page will result in a cache MISS. Kind regards |
Hi @engcom-Dash Please could you check this issue again. You will be able to confirm by the additional information I have provided. Im sure with tis you will be able to confirm the issue. Kind regards |
Hi @ahmed-midori , Verified the issue in 2.4-develop instance and the issue is reproducible as per your last comment,Hence we are confirming the issue. Kindly refer the below screenshots: |
✅ Jira issue https://jira.corp.adobe.com/browse/AC-9284 is successfully created for this GitHub issue. |
✅ Confirmed by @engcom-Dash. Thank you for verifying the issue. |
❌ You don't have permission to export this issue. |
Hi @engcom-Dash |
any update on this? |
any fix ? |
Hi @ahmed-midori, Thanks for your reporting and collaboration. We have tried to reproduce the issue in latest 2.4-develop instance and the issue is no more reproducible.Kindly refer the screenshots. ![]() ![]() ![]() Hence we are closing this issue. Thanks. |
Preconditions and environment
Steps to reproduce
The below issues have been found on a production site as well as a clean Magento install with sample data.
Issue 1 (product changes to out of stock):
If a shipment is created for the last available qty of a product making the product out of stock the complete site cache is invalidated.
Issue 2(Change to a product created in admin):
If any change is made to a product in admin such as change to product title or description then this also completely invalidates all cache site wide.
Expected result
Cache to be invalidated only for the product and the categories containing that product.
Actual result
Complete cache invalidation
Additional information
It is a huge inconvenience and not practical if you are running a site with many categories and 10's of thousands of products to have all cache invalidated just because a single product goes out of stock or a single product is edited.
Release note
No response
Triage and priority
The text was updated successfully, but these errors were encountered: