Skip to content

"Pagination Frame Skip" not working in Single Store mode #38256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 5 tasks
dchaykas opened this issue Dec 8, 2023 · 10 comments
Closed
1 of 5 tasks

"Pagination Frame Skip" not working in Single Store mode #38256

dchaykas opened this issue Dec 8, 2023 · 10 comments
Labels
Area: Content Component: Frontend Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: ready for confirmation Priority: P3 May be fixed according to the position in the backlog. Progress: dev in progress Reported on 2.4.5-p3 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@dchaykas
Copy link

dchaykas commented Dec 8, 2023

Preconditions and environment

  • 2.4.5-p3
  • Single Store Mode enabled
  • Singe Website, single store, single store view configuration

Steps to reproduce

  1. In Admin, navigate to Content -> Configuration.
  2. A single grid entry should be visible, click "Edit" in Action column. This is a website scope entry.
  3. Scroll down to "Pagination" section
  4. Set "Pagination Frame Skip" to 10 (or a value according to the result set size so that pagination is visible)

Expected result

Pagination frame skip should be visible on the frontend with skip frame "..." when permitted.

Actual result

Pagination frame skip is not visible.

Additional information

This is happening because the "pagination frame skip" configuration is explicitly fetched for the Store scope.
vendor/magento/module-catalog/Block/Product/ProductList/Toolbar.php:692 getPagerHtml function

)->setJump(
                $this->_scopeConfig->getValue(
                    'design/pagination/pagination_frame_skip',
                    \Magento\Store\Model\ScopeInterface::SCOPE_STORE
                )

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Dec 8, 2023

Hi @dchaykas. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@dchaykas
Copy link
Author

dchaykas commented Dec 8, 2023

@magento give me 2.4-develop instance

Copy link

Hi @dchaykas. Thank you for your request. I'm working on Magento instance for you.

Copy link

@engcom-Dash engcom-Dash self-assigned this Dec 10, 2023
Copy link

m2-assistant bot commented Dec 10, 2023

Hi @engcom-Dash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

    1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
    1. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
    1. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

@engcom-Bravo engcom-Bravo added the Reported on 2.4.5-p3 Indicates original Magento version for the Issue report. label Dec 12, 2023
@engcom-Bravo engcom-Bravo self-assigned this Dec 12, 2023
Copy link

m2-assistant bot commented Dec 12, 2023

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo
Copy link
Contributor

Hi @dchaykas,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Steps to reproduce

  • In Admin, navigate to Content -> Configuration.
  • A single grid entry should be visible, click "Edit" in Action column. This is a website scope entry.
  • Scroll down to "Pagination" section
  • Set "Pagination Frame Skip" to 10 (or a value according to the result set size so that pagination is visible)

Main-Website-Design-Content-Magento-Admin

Tops-Men

Pagination frame skip is not visible.

Hence Confirming the issue.

Thanks.

@engcom-Bravo engcom-Bravo added Area: Content Component: Frontend Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Dec 12, 2023
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-10673 is successfully created for this GitHub issue.

@engcom-Bravo engcom-Bravo added Priority: P3 May be fixed according to the position in the backlog. Issue: ready for confirmation labels Dec 12, 2023
Copy link

m2-assistant bot commented Dec 12, 2023

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-Bravo
Copy link
Contributor

Hi @dchaykas,

Thanks for your reporting and collaboration.

We have tried to reproduce the issue in Latest 2.4-develop instance and the issue is no more reproducible.Hence we are closing this issue.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Content Component: Frontend Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: ready for confirmation Priority: P3 May be fixed according to the position in the backlog. Progress: dev in progress Reported on 2.4.5-p3 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Development

No branches or pull requests

4 participants