-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Pagebuilder Minimum Height acting as both Minimum and Maximum #38310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @ZandaBear. Thank you for your report.
Join Magento Community Engineering Slack and ask your questions in #github channel. |
Hi @engcom-Bravo. Thank you for working on this issue.
|
Hi @ZandaBear, Thank you for reporting and collaboration. Verified the issue on Magento 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshots. Steps to reproduce
row or element will scale in accordance with setting (cover, contain, auto) with a minimum height of 200px Kindly recheck the behaviour on Magento 2.4-develop instance and elaborate steps to reproduce if the issue is still reproducible. Thanks. |
All reactions
Sorry, something went wrong.
Hey @engcom-Bravo, Correction, it appears "Media -> Image" is the only one functioning correctly. Updated initial report to match. As you can see pictured, with "Banner" all three modes, in order from top to bottom of Cover, Contain, Auto are incorrectly locking the height at 100px. So, the issue appears to be encountered when doing the following... A similar, but different issue encounter is that the image will always look like the top-most "cover" instance in the screenshot when... |
All reactions
Sorry, something went wrong.
@magento give me 2.4-develop instance |
All reactions
Sorry, something went wrong.
Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you. |
All reactions
Sorry, something went wrong.
Hi @engcom-Bravo, here is your Magento Instance: https://9e16d494a579cd79c152743d1c622f0a.instances-prod.magento-community.engineering |
All reactions
Sorry, something went wrong.
Hi @ZandaBear, Thanks for your update. Verified the issue on Magento 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshots. Steps to reproduce
row or element will scale in accordance with setting (cover, contain, auto) with a minimum height of 100px. Kindly recheck the behaviour on Magento 2.4-develop instance and elaborate steps to reproduce if the issue is still reproducible. Thanks. |
All reactions
Sorry, something went wrong.
@magento give me 2.4-develop instance |
All reactions
Sorry, something went wrong.
Hi @ZandaBear. Thank you for your request. I'm working on Magento instance for you. |
All reactions
Sorry, something went wrong.
Hi @ZandaBear, here is your Magento Instance: https://9e16d494a579cd79c152743d1c622f0a.instances-prod.magento-community.engineering |
All reactions
Sorry, something went wrong.
@engcom-Bravo If you are setting the row to 100px then of course you must verify that the element's minimum height is not set to a greater value. For example, by default Magento sets banners to have a minimum height of 300px. See screenshot for proof of the behavior I described in the initial post from the developer instance. For the screenshot, Row minimum height was set to 100px. Banner minimum height was cleared. Verified same behavior when the Row minimum height is cleared and Banner minimum is set to 100px. As you can see, page-builder is not scaling banners or sliders in accordance with a minimum of 100px for the element. It is stretching or cropping the image used to a set height of 100px. The headers describe what each element is using. Only the top one is the correct size for the image of 200x200px. |
All reactions
Sorry, something went wrong.
Hi @ZandaBear, Thanks for your update. Verified the issue on Magento 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots. Steps to reproduce
page-builder is not scaling banners or sliders in accordance with a minimum of 100px for the element.Only the top one is the correct size for the image Hence Confirming the issue. Thanks. |
All reactions
Sorry, something went wrong.
✅ Jira issue https://jira.corp.adobe.com/browse/AC-10789 is successfully created for this GitHub issue. |
All reactions
Sorry, something went wrong.
✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue. |
All reactions
Sorry, something went wrong.
Has there been any progress on this ticket or does anyone have a fix? |
All reactions
Sorry, something went wrong.
No branches or pull requests
Uh oh!
There was an error while loading. Please reload this page.
Preconditions and environment
Steps to reproduce
Expected result
Said row or element will scale in accordance with setting (cover, contain, auto) with a minimum height of 100px
Actual result
Row or element is locked to 100px height. Image will be cropped, or scale reduced to fit within the so-called "minimum" height.
Additional information
Current workaround is to add a text box and, using the built in WYSIWYG, add an image. This allows admin to set both the height and width to scale however desired, but loses the functionality of the other elements available.
Release note
No response
Triage and priority
The text was updated successfully, but these errors were encountered: