Category Rewrites are generating even if config is disabled

[sheepfy]

Preconditions and environment

• Magento version: 2.4.7-p1, 2.4.7-p2

The old version had this if statements:
if ($this->isCategoryRewritesEnabled()) {

https://github.com/magento/magento2/blob/2.4.6-p1/app/code/Magento/CatalogUrlRewrite/Model/ProductScopeRewriteGenerator.php

Checking now the 2.4.7-p1 version, seems that the generation logic was moved into a separate method:
private function generateCategoryUrls(int $storeId, Product $product, ObjectRegistry $categories): array

But the IF statement was forgot to be added. (Also if checking the other category generation method "generateCategoryUrlsInStoreGroup", that one contains the IF statement)

https://github.com/magento/magento2/blob/2.4.7-p1/app/code/Magento/CatalogUrlRewrite/Model/ProductScopeRewriteGenerator.php

Steps to reproduce

Set the admin config: catalog/seo/generate_category_product_rewrites to 0 (it should be by default set to 0)
Save a product/create a product and then check the url rewrites

Note that in order to trigger the url generation, you need to have data changes on the product. For example, do change visibility from Catalog, Search to Catalog to trigger it

Expected result

Have only product rewrite

Actual result

Have category rewrites + product rewrite

Additional information

No response

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @sheepfy. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant]

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Bravo]

Hi @sheepfy,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Having category rewrites + product rewrite

Hence Confirming the issue.

Thanks.

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.adobe.com/browse/AC-12801 is successfully created for this GitHub issue.

[m2-assistant]

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[rogerdz]

same #38317

[hostep]

This issue can be closed. It seems fixed in Magento 2.4.8.
It seems it got fixed by this commit: e6d6b36?w=1 (which is part of these larger changes in ACP2E-3383: Incorrect url_rewrite entries creation with multiple stores in one store group)

[ihor-sviziev]

I'm closing this issue as it was already fixed.
More details in #39070 (comment)