[2.4.7-p3] Duplicate image when product is edited through API

[iwanzijderveld]

Preconditions and environment

• Magento version 2.4.7-p3
• Product bulk API - Run bin/magento queue:consumers:start async.operations.all

Steps to reproduce

1. Post a product with one image using BASE64 format option on BULK API endpoint rest/all/async/bulk/V1/products
2. Go to the product in the admin.
3. See that 1 image is imported.
4. Post the same request again
5. See that the same image is added twice

Expected result

Existing image to be overridden.

Actual result

Image is duplicated

Additional information

No response

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @iwanzijderveld. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant]

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Delta]

Hi @iwanzijderveld ,

Thanks for your reporting and collaboration.
We have verified the issue in Latest 2.4-develop instance and the issue is reproducible. Kindly refer the screenshots.

Steps to reproduce

1. Post a product with one image using BASE64 format option on BULK API endpoint rest/all/async/bulk/V1/products
2. Go to the product in the admin.
3. See that 1 image is imported.
4. Post the same request again
   
5. See that the same image is added twice
   

Thanks.

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.adobe.com/browse/AC-13337 is successfully created for this GitHub issue.

[m2-assistant]

✅ Confirmed by @engcom-Delta. Thank you for verifying the issue.
Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[Denis2310]

Hello,

Are there any news regarding this issue? It has been 5 months since this was reported. Magento 2.4.8 has been release and I didn't find anything regarding this issue.

[KrasnoshchokBohdan]

@magento I am working on this

[KrasnoshchokBohdan]

@engcom-Delta @iwanzijderveld
I spent some time reviewing code and testing. Please review and correct me if I am wrong or have misunderstood something.

for tests i used

rest/all/async/bulk/V1/products

with body

[
    {
        "entity_type": "products",
        "entity_id": null,
        "action": "create",
        "product": {
            "sku": "test2",
            "name": "Example Product",
            "attribute_set_id": 4,
            "price": 29.99,
            "status": 1,
            "visibility": 4,
            "type_id": "simple",
            "weight": "1.0",
            "extension_attributes": {
                "stock_item": {
                    "qty": 100,
                    "is_in_stock": true
                }
            },
            "media_gallery_entries": [
                {
                    "media_type": "image",
                    "label": "Main Image",
                    "position": 1,
                    "disabled": false,
                    "types": ["image", "small_image", "thumbnail"],
                    "content": {
                        "base64_encoded_data": "iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAYAAABzenr0AAAAKklEQVR42u3NQQEAAAQEsJNcdFLw2gqsMOL5czgdQIAAAQIECBAgQIDAXwE4mAACqEGDJQAAAABJRU5ErkJggg==",
                        "type": "image/png",
                        "name": "test.png"
                    }
                }
            ],
            "custom_attributes": [
                {
                    "attribute_code": "description",
                    "value": "Product description here"
                }
            ]
        }
    }
]

\Magento\Catalog\Model\Product::setMediaGalleryEntries
\Magento\Catalog\Model\Product\Attribute\Backend\Media\ImageEntryConverter::convertFrom

first clue, in body I didn't give "id" param in "media_gallery_entries"

\Magento\Catalog\Model\ProductRepository\MediaGalleryProcessor::processMediaGallery

with no "value_id" entry will go to "$newEntries" array

admin product edit page

"catalog_product_entity_media_gallery" table

let's add "id" param with another base64 image to body

[
    {
        "entity_type": "products",
        "entity_id": null,
        "action": "create",
        "product": {
            "sku": "test2",
            "name": "Example Product",
            "attribute_set_id": 4,
            "price": 29.99,
            "status": 1,
            "visibility": 4,
            "type_id": "simple",
            "weight": "1.0",
            "extension_attributes": {
                "stock_item": {
                    "qty": 100,
                    "is_in_stock": true
                }
            },
            "media_gallery_entries": [
                {
                    "id": 15,
                    "media_type": "image",
                    "label": "Main Image",
                    "position": 1,
                    "disabled": false,
                    "types": ["image", "small_image", "thumbnail"],
                    "content": {
                        "base64_encoded_data": "iVBORw0KGgoAAAANSUhEUgAAAAoAAAAKCAYAAACNMs+9AAAAIElEQVR42mNkYGD4z0AEYBxVOGoQFYYxMDAwMDIy8uEDAHSMBYayxwWvAAAAAElFTkSuQmCC",
                        "type": "image/png",
                        "name": "test.png"
                    }
                }
            ],
            "custom_attributes": [
                {
                    "attribute_code": "description",
                    "value": "Product description here"
                }
            ]
        }
    }
]

check admin product edit page and "catalog_product_entity_media_gallery" table

my conclusion - we should add "id" param to body if we want to change existing entity
(we can get "id" from responce GET /rest/V1/products/{sku})