As a developer, I am confused about the current state of the Magento license.

[damienwebdev]

{}Issue description{}:

We are receiving escalations from the community that we there are still Magento Open Source where Adobe confidential copyright notice is being used instead of s reduced open source form of copyright. Please see examples below:

• <https://github.com/magento/magento2/issues/39493]
  https://github.com/search?q=repo%3Amagento%2Fmagento2%20All%20information%20contained%20herein%20is%2C%20and%20remains&type=code

In scope of this ticket we need to find all the files under the Magento Open Source repository [https://github.com/magento/magento2] where we still continue using confidential notice and remove it.  

{}Acceptance criteria{}:

• There are no any files in the [https://github.com/magento/magento2] repo which have [^{Adobe Confidential copyright.pdf]notice in it and the reduced form of Adobe copyright is being used instead [}Reduced form Copyright.pdf>
• Files with old Magento copyright should remain unchanged. 

[m2-assistant]

Hi @damienwebdev. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[rhoerr]

Related:
#37631 (comment)
#39099 (comment)

[ihor-sviziev]

@sidolov, could you please reply? Will all these Adobe notices be removed from the Magento Open Source version?

[chernenm]

hi @ihor-sviziev, @damienwebdev, this notice was used by our Adobe internal team member by mistake, we will remove it asap.

[hostep]

@chernenm: it would help a lot if the new copyright format is being fully validated by your coding standards tool, right now it only checks for the first line and doesn't care what other lines follow. If this can be checked fully, this problem wouldn't have happened probably.
Also having some documentation being published about it for the non-Adobe contributors here on github would help significantly for people who don't know yet about this new format.

[engcom-Bravo]

Hi @damienwebdev,

Thanks for your reporting and collaboration.

Adobe Commerce Engineering team started working on this issue. We will reach out to you if we need more information and you will get notified once the issue is fixed. Please leave comments for any further questions.

Hence moving this issue to ON HOLD.

Thank you!

[hostep]

@engcom-Bravo, @chernenm: why did this issue got closed automatically without any comments explaining why exactly?

Update: probably because of 1c6bb3c & 478b961? It's not a full fix however, just a cleanup action, if this isn't being guarded by automation, this has a chance of happening again...

[engcom-Charlie]

Hello,

The issue got fixed in the https://github.com/search?q=repo%3Amagento%2Fmagento2+public_copyright&type=commits

Thank you!

[ihor-sviziev]

@engcom-Charlie @engcom-Hotel,
I see that the issue appeared again in 5 files https://github.com/search?q=repo%3Amagento%2Fmagento2%20All%20information%20contained%20herein%20is%2C%20and%20remains&type=code
Could you please implement a fix that makes sure no such notice appear in the public repo?

[adamwaclawczyk]

It's now in 54 files https://github.com/search?q=repo%3Amagento%2Fmagento2%20All%20information%20contained%20herein%20is%2C%20and%20remains&type=code

[ihor-sviziev]

@engcom-Bravo @engcom-Charlie @engcom-Hotel could you please make sure it's fixed and all needed internal processes / automations are aligned with it?

[hostep]

Detecting this automatically would be the ideal solution, so it would be appreciated if magento/magento-coding-standard#492 could be tackled as well at the same time as the cleanup.

Also this query is better, to search in all repositories belonging to magento: https://github.com/search?q=org%3Amagento%20All%20information%20contained%20herein%20is%2C%20and%20remains&type=code, because this wrong copyright is used in plenty of other magento repositories.

[engcom-Charlie]

Thank you @hostep @ihor-sviziev @damienwebdev @adamwaclawczyk for you input.

Adobe Commerce Engineering team started working on this issue. We will reach out to you if we need more information and you will get notified once the issue is fixed. Please leave comments for any further questions. Thank you!

[engcom-Bravo]

Hello,

The issue got fixed in the https://github.com/search?q=repo%3Amagento%2Fmagento2+AC-14425&type=commits

Based on the Jira ticket, the target version is 2.4.9-alpha1.

Thanks.

[hostep]

Great that is one small step forwards, but @engcom-Bravo, wrong copyright headers are still being created by Adobe devs in other repositories, like this commit that landed today: magento/adobe-stock-integration@3d08c60

Ideally, this search should return 0 results if all code is cleaned up: https://github.com/search?q=org%3Amagento+%22All+information+contained+herein+is%2C+and+remains%22&type=code

I keep repeating myself but this should be checked in your coding standards, so that static tests will detect the wrong usage and complain about it.

[hostep]

@engcom-Bravo: please re-open ticket and solve it properly by checking with static test so that it no longer is allowed to happen, because Adobe devs keep on putting wrong copyright headers in the codebase: 729da18 (added 6 hours ago at time of writing)