-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Previously fixed isses with TinyMCE have not been backported in latest security patch #39628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @dmf-janw. Thank you for your report.
Join Magento Community Engineering Slack and ask your questions in #github channel. |
Yeah, I noticed the same last week and brought it to the attention of the security team on Slack to try to get those fixes included in the next security releases (in April 2025), no positive feedback yet besides the fact that they told me they would consider it. |
Hi @engcom-Hotel. Thank you for working on this issue.
|
Thanks @dmf-janw for raising the concern! We are confirming this issue to speed-up the things. Thanks again. |
✅ Jira issue https://jira.corp.adobe.com/browse/AC-14160 is successfully created for this GitHub issue. |
✅ Confirmed by @engcom-Hotel. Thank you for verifying the issue. |
@engcom-Hotel How soon will it be done? |
Hello @surajpteamwass, As I can see in its related JIRA, it has not been picked by any internal developer yet. Currently internal team is occupied in some high priority tasks. Will let you know if I got any updates. Thanks |
Thanks @engcom-Hotel i got an alternate solution for this problem and that is working. 'minify_exclude' => [ |
Preconditions and environment
With the downgrade from TinyMCE 7 back to version 6 a few previously fixed issues have been reintroduced. Namely #39262 and #39263.
For #39263 the relevant change done in d1b5797 is only present in the
2.4.8-beta2
release tag. In all four release tags of the latest security patch (2.4.4-p12
,2.4.5-p11
,2.4.6-p9
and2.4.7-p4
) the exclude path still refers to the now incorrect/tiny_mce/
path.Similarly, the PR which fixes #39262 (https://github.com/magento/magento2/pull/39258/files, a71df16) is not present in any of the latest tags as well.
Steps to reproduce
The erroneous behaviour of #39263 can be reproduced by enabling production mode and javascript minification and attempting to use TinyMCE in the admin area.
#39262 is not triggered in the default configuration. The plugins are attempted to be loaded if, as described in the original issue, one has the module
Magenerds_PageDesigner
installed (see: Magenerds/PageDesigner#54).Expected result
TinyMCE 6 works in the default configuration with JavaScript minification enabled and
Magenerds_PageDesigner
(or any other method of attempting to load the plugins in the editor) installed.Actual result
TinyMCE6 fails to load in the aforementioned circumstances.
Additional information
This can be worked around manually.
#39263 can be fixed by adding something akin to:
to
config.php
.#39262 can only be fixed by manually patching the contents of
lib/web/mage/adminhtml/wysiwyg/tiny_mce/plugins/magentovariable/editor_plugin.js
andlib/web/mage/adminhtml/wysiwyg/tiny_mce/plugins/magentowidget/editor_plugin.js
. Both paths are located in thelib
directory which is supposed to be added by the installation process and not be edited manually. This introduces additional maintenance load for every installation, as the change will have to be manually carried over for each subsequent patch in which the bug is still present.Release note
No response
Triage and priority
The text was updated successfully, but these errors were encountered: